Temporarily skip hipGraph version of LargeIndices test #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there appear to be some problems calling the atomicAdd function within hipGraphs on some architectures. The atomicAdd function is called within the device_adjacent_difference algorithm's LargeIndices test (check_output class) to increment a counter value. As a result, the hipGraph version of the test fails when called on affected architectures. This change temporarily skips the hipGraph version of the test. We can re-enable it when the root cause has been addressed.
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
RobsonRLemos
approved these changes
Feb 8, 2024
umfranzw
merged commit 435f7f4
into
ROCm:release-staging/rocm-rel-6.1
15 of 17 checks passed
stanleytsang-amd
pushed a commit
to stanleytsang-amd/rocPRIM
that referenced
this pull request
Apr 17, 2024
…ff_test Temporarily skip hipGraph version of LargeIndices test
stanleytsang-amd
added a commit
that referenced
this pull request
Apr 18, 2024
* Merge pull request #525 from umfranzw/disable_hipgraph_dev_adj_diff_test Temporarily skip hipGraph version of LargeIndices test * Update changelog --------- Co-authored-by: Wayne Franz <wayfranz@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there appear to be some problems calling the atomicAdd function within hipGraphs on some architectures. The atomicAdd function is called within the device_adjacent_difference algorithm's LargeIndices test (check_output class) to increment a counter value. As a result, the hipGraph version of the test fails when called on affected architectures.
This change temporarily skips the hipGraph version of the test. We can re-enable it when the root cause has been addressed.