Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit testing to verify that algorithms work with hipGraphs #478

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Add unit testing to verify that algorithms work with hipGraphs #478

merged 8 commits into from
Nov 22, 2023
+2,629 −297

Commits on Nov 19, 2023

  1. Basic hipGraph tests 

    * Add basic tests for graph creation, instantiation, and execution using:
  * stream capture
  * manual construction
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    f4e5cf1 View commit details
    Browse the repository at this point in the history

  2. hipGraph test for device_reduce algorithms 

    * Added new unit tests for device_reduce, device_reduce_by_key algorithms
to verify basic support for hipGraphs (no synchronous API functions are
called within the algorithms).
* Fixed up CMakeLists compile issue for tests in the test/hipgraph folder
* Updated code documentation
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    134647d View commit details
    Browse the repository at this point in the history

  3. Add hipGraph unit tests for device level algorithms 

    * Added unit tests that run the following algorithms inside of a graph
(in isolation):
  - device_adjacent_difference
  - device_binary_search
  - device_histogram
  - device_merge
  - device_merge_sort
  - device_partition
  - device_radix_sort
  - device_scan
  - device_segmented_reduce
  - device_segmented_scan
  - device_select
  - device_transform

* Updated existing tests for:
  - device_reduce
  - device_reduce_by_key

* Moved graph test helper functions to a separate file
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    67aa806 View commit details
    Browse the repository at this point in the history

  4. Add hipGraph unit tests 

    * Added remaining device level hipGraph unit tests

* Note: currently, there are two device level algorithms that
do no work with hipGraphs because they contain synchronization
barriers. No hipGraph unit tests have been added for these
algorithms:
  * device_run_length_encode
  * device_segmented_radix_sort

* Added a functional integration test for hipGraphs, which
runs several algorithms back-to-back within a graph.

* Refactored test helper code to remove unnecessary parameter
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    e8a9c0f View commit details
    Browse the repository at this point in the history

  5. Set hipgraph test pointers to nullptr 

    * Set key_type device pointers to nullptr when they are declared, for
  safety.
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    46d1f7c View commit details
    Browse the repository at this point in the history

  6. Several minor fixes for hipGraph tests 

    * Fixed up spelling error in comments
* Moved call to hipGetLastError to a more appropriate position
* Removed old commented test code
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    7842204 View commit details
    Browse the repository at this point in the history

  7. Minor fixes for hipgraph unit tests 

    * Moved several synchronization barriers so they are now outside of graph capture blocks
  in the test_device_partition source
* Changed several loop counters to unsigned type
* Updatedpgraph  cmake files - removed test/hipgraph
  directory's CMakeLists.txt
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    600509e View commit details
    Browse the repository at this point in the history

  8. Additional test and bugfix for hipgraph tests 

    * Removed syncrhonization barrier in test_device_scan
* Added basic test to exercise atomic function within a hipgraph
* Rebased and resolved merge conflicts
    @umfranzw
    umfranzw committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    8ad9df2 View commit details
    Browse the repository at this point in the history