Skip to content

Refactor Python files to align with enabled Python tidy and formatter #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Refactor Python files to align with enabled Python tidy and formatter #1997

wants to merge 39 commits into from
+3,455 −2,571

Conversation

dorde-antic
Copy link
Contributor

@dorde-antic dorde-antic commented Sep 24, 2025 •
edited
Loading

Motivation

Resolves https://github.com/ROCm/rocMLIR-internal/issues/1884

Technical Details

Refactors python files to conform to yapf, flake8 and pep8-naming conventions for consistent style and code quality.

Test Plan

  1. Weekly
  2. Nightly
  3. PR CI
  4. tuningRunner and perfRunner locally
  5. bank_conflicts.py and other widgets ?

Test Result

  1. PR CI ✅
  2. Nightly ⌛
  3. Weekly - Param. Sweeps ✅
  4. Weekly - Tuning ⌛
  5. tuningRunner and perfRunner
    • ON MFMA:
      • Done for ATTN ✅
      • Done for GEMM✅
      • Done for CONV ✅
    • ON WMMA:
      • Done for ATTN ✅
      • Done for GEMM✅
      • Done for CONV ✅

Submission Checklist

@dorde-antic
Initial commit
30c2a69
@dorde-antic
Align AmdDeviceLibsIncGen with flake8
a23aae8
@dorde-antic
Adjust lit.cfg.puy f
cb3b681
@dorde-antic
Resolve F401 error
e675664
@dorde-antic
Resolve E266 error
da3b7f1
@dorde-antic
Resolve F841, N802, N806, N816 in generateE2ETest.py and generate-fus…
eeb74a7 
…ion-tests.py
@dorde-antic
Adjust comparison with None and functions, variables, arguments name
db58d43
@dorde-antic
Change reportUtils/geoMean() everywhere where its imported
f3b5af4
@dorde-antic
Resolve N806 and N803 in reportUtils.py
3a5bf8a
@dorde-antic
Resolve N802 in reportUtils and adjust files where methods were imported
b8ed025
@dorde-antic
Adjust bank_conflicts.py
ab7bb41
@dorde-antic
Decorate class methods with @staticmethod to resolve N805
3a15843
@dorde-antic
generate-fusion-tests.py adjust
e61148b
@dorde-antic
Resolve flake8 issues on premerge-checks
ca18539
@dorde-antic
Resolve flake8 issues on reportUtils
45bf0e6
@dorde-antic
Refactor tuningRunner, adjust .flake8 and ci.yml with yapf
d85fd74
@dorde-antic
Newline on flake8
f181916
@dorde-antic
Merge branch 'develop' into refactor_py_files_i1904
78c46fa
@dorde-antic
Apply yapf on perfRunner and tuningRunner
4470166
@dorde-antic
Resolve N802 in perfRunner and sync with files which reuse module
c8864a3
@dorde-antic
N806 perfRunner part 1
9bf9823
@dorde-antic
Resolve N803, N806 in perfRunner
79294d8
@dorde-antic
W291, E128 in perfRunner and extend ignore with W605
98e4176
@dorde-antic
DONE: perfRunner
da28cc7
@dorde-antic
flake8 and yapf perfRegressionReport.py
ba473d9
@dorde-antic
perfCommonUtils refactor and adjust where imported
50f3d29
@dorde-antic
N802 in parameterSweeps and attentionSweeps
2b11b07
@dorde-antic
N803 in param. sw.
f864a9a
@dorde-antic
flake8 on param sw
8638b6c
@dorde-antic
param sw done
317cfb0
@dorde-antic dorde-antic marked this pull request as ready for review September 29, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@causten causten Awaiting requested review from causten causten is a code owner

@dhernandez0 dhernandez0 Awaiting requested review from dhernandez0

@mirza-halilcevic mirza-halilcevic Awaiting requested review from mirza-halilcevic

@umangyadav umangyadav Awaiting requested review from umangyadav

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dorde-antic