Skip to content

Implement GQA in AttentionConfiguration #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025
Merged

Conversation

dorde-antic
Copy link
Contributor

@dorde-antic dorde-antic commented May 21, 2025

Resolves https://github.com/ROCm/rocMLIR-internal/issues/1834

@dorde-antic dorde-antic requested a review from causten as a code owner May 21, 2025 14:57
@dorde-antic dorde-antic force-pushed the gqa-attnconf-perfrunner branch from 1786cd1 to cc9a0d2 Compare May 22, 2025 10:46
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1847      +/-   ##
===========================================
- Coverage    78.52%   78.18%   -0.34%     
===========================================
  Files          100      100              
  Lines        29907    30944    +1037     
  Branches      4452     4793     +341     
===========================================
+ Hits         23482    24192     +710     
- Misses        4590     4657      +67     
- Partials      1835     2095     +260     
Flag Coverage Δ
mfma 78.17% <ø> (-0.35%) ⬇️
navi3x 78.18% <ø> (?)
navi4x 78.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dorde-antic dorde-antic requested a review from dhernandez0 May 27, 2025 10:53
@dorde-antic dorde-antic merged commit 417ec20 into develop May 27, 2025
15 of 26 checks passed
@dorde-antic dorde-antic deleted the gqa-attnconf-perfrunner branch May 27, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants