Skip to content

Conversation

@ronlieb
Copy link
Collaborator

@ronlieb ronlieb commented Nov 28, 2025

…486)

Attempt to only define used subregisters when creating IMPLICIT_DEF fix ups for live interval subranges. This avoids the appearance at the MIR level of entire (wide) registers becoming live rather than relying only on transient LiveIntervals dead definitions for unused subregisters.

(cherry picked from commit b1c4b55)

…#167486)

Attempt to only define used subregisters when creating IMPLICIT_DEF fix
ups for live interval subranges. This avoids the appearance at the MIR
level of entire (wide) registers becoming live rather than relying only
on transient LiveIntervals dead definitions for unused subregisters.

(cherry picked from commit b1c4b55)
Copy link
Collaborator

@searlmc1 searlmc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@saipoorna saipoorna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronlieb
Copy link
Collaborator Author

ronlieb commented Nov 29, 2025

!PSDB

@ronlieb ronlieb closed this Nov 29, 2025
@ronlieb ronlieb reopened this Nov 29, 2025
@ronlieb ronlieb closed this Nov 29, 2025
@ronlieb ronlieb reopened this Nov 29, 2025
@ronlieb ronlieb closed this Nov 29, 2025
@ronlieb ronlieb reopened this Nov 29, 2025
@ronlieb ronlieb closed this Nov 29, 2025
@ronlieb ronlieb reopened this Nov 29, 2025
@ronlieb
Copy link
Collaborator Author

ronlieb commented Nov 29, 2025

@rahulc-gh could this PR be marked passing ? npsdb is failing rocgdb test
http://rocm-ci.amd.com/job/compute-psdb-rel-7.2/47/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants