[OpenMP] Fix use_device_ptr(addr) mappings for Fortran Pointer types #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agozillon
approved these changes
Jul 12, 2024
|
and also to add to the last comment about the tests, I think they'll likely just fail at the moment without the other part of the PR stack! so probably best they're left out for now. Otherwise everything else LGTM! |
llvm#96265 changes are required for this to work.
TIFitis
force-pushed
the
akash/atd-use-device-mapping
branch
from
257641a
to
76e5ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test in https://ontrack-internal.amd.com/browse/SWDEV-471469.
This fix also depends on @agozillon patch llvm#96265.