Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported Row-Major memory order #108

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Supported Row-Major memory order #108

merged 3 commits into from
Jun 25, 2024

Conversation

vin-huang
Copy link
Collaborator

  1. Supported Row-Major Memory order for the Matrix A/B/C/D.
  2. Supported mixed row/col memory order for the SPMM

@vin-huang vin-huang added the gfx94x Run CI on gfx94x label May 16, 2024
@vin-huang
Supported Row-major order.
2bceff7 
  *Prune, Compress and SPMM
  *Matrix C and D must in same memory order
  *Matrix A/B/C(D) can be different memory order
  *Refactor RocsparseltContractionProblem
  *Prepare the infoarmtion for spmm kernel when create matmul descriptor.
@vin-huang
Update Logic YAMLs for Row-Major order.
55a4ec5 
  * Modified UseBias value to 3
  * Add tag BDMN in to kernel name and yaml file name.
@vin-huang
Enable Row-major order in clients.
428a7e6 
  *Add Parameter: order for bench and unit test
  *Add unit test for row-major order: Prune, Compress and SPMM
  *Used CblasRowMajor for cblas_gemm instead of swaping A and B matrixs and plus CblasOrderMajor
  *Supported A,B,C(D) can be different order in client
  *Add test for Matrix A/B in order [R, C]
hcman2
hcman2 approved these changes Jun 20, 2024
View reviewed changes
Copy link

@hcman2 hcman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK if Ci pass.

@vin-huang vin-huang merged commit df9ac62 into ROCm:develop Jun 25, 2024
7 checks passed
@vin-huang vin-huang deleted the row_col_order_mix branch June 25, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcman2 hcman2 hcman2 approved these changes

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

Assignees
No one assigned
Labels
gfx94x Run CI on gfx94x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vin-huang @hcman2