[CK_TILE] Tune fmha fwd splitkv codgen #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poyenc
changed the title
rocking5566
reviewed
Dec 17, 2024
| { | ||
| int device; | ||
| auto status = hipGetDevice(&device); | ||
| if(status != hipSuccess) | ||
| { |
There was a problem hiding this comment.
follow FA coding style
if(status != hipSuccess) { return num_splits; }
rocking5566
reviewed
Dec 17, 2024
|
|
||
| hipDeviceProp_t props{}; | ||
| status = hipGetDeviceProperties(&props, device); | ||
| if(status != hipSuccess) | ||
| { | ||
| return num_splits; |
There was a problem hiding this comment.
if(status != hipSuccess) { return num_splits; }
rocking5566
reviewed
Dec 17, 2024
| // get kM0 for prefill phase | ||
| if(is_prefill) | ||
| { | ||
| return 128; |
rocking5566
reviewed
Dec 17, 2024
| }; | ||
|
|
||
| for(auto [hdim, m0] : hdim_to_m0) | ||
| { |
rocking5566
reviewed
Dec 17, 2024
| { | ||
| if(hdim_q <= hdim && hdim_v <= hdim) | ||
| { | ||
| return m0; |
rocking5566
reviewed
Dec 17, 2024
|
|
||
| if(num_splits < 1 && p_drop == 0.0f) | ||
| return num_splits_heuristic_ck( | ||
| batch * nhead * num_m_blocks, props.multiProcessorCount * 2, num_n_blocks, 128); | ||
| { |
rocking5566
reviewed
Dec 17, 2024
| if (batch_nheads_mblocks >= 0.8f * num_SMs) { return 1; } | ||
| max_splits = std::min({max_splits, num_SMs, num_n_blocks}); | ||
| if(batch_nhead_mblocks >= 0.8f * num_SMs) | ||
| { |
rocking5566
reviewed
Dec 17, 2024
| std::array<float, num_splits_array.size()> efficiency; | ||
|
|
||
| for(size_t idx = 0; idx < num_splits_array.size() && num_splits_array[idx] <= max_splits; ++idx) | ||
| { |
rocking5566
reviewed
Dec 17, 2024
| float eff = n_blocks / std::ceil(n_blocks); | ||
|
|
||
| if(eff > max_efficiency) | ||
| { |
rocking5566
reviewed
Dec 17, 2024
| // printf("num_splits chosen = %d\n", num_splits); | ||
| return num_splits; | ||
| for(size_t idx = 0; idx < num_splits_array.size() && num_splits_array[idx] <= max_splits; ++idx) | ||
| { |
poyenc
force-pushed
the
ck_tile/vllm-layout-varlen-add-splitkv-instance
branch
from
c44f7a7 to
ddcc375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see CK PR for more info.