[CK_TILE][FMHA] Enable wholek_prefetch - #3026
Closed
LJ-underdog wants to merge 16 commits into
Closed
Conversation
Signed-off-by: JL-underdog <Jun.Lin@amd.com>
Contributor
|
@LJ-underdog are you still working on this? |
Contributor
Author
yes， this pr is prepare for mate |
LJ-underdog
marked this pull request as ready for review
January 13, 2026 02:33
LJ-underdog
requested review from
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent and
vidyasagar-amd
as code owners
January 13, 2026 02:33
LJ-underdog
changed the title
Signed-off-by: Linjun-AMD <Jun.Lin@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables a new whole-K prefetch pipeline variant for the FMHA (Flash Multi-Head Attention) operations. The change introduces a new pipeline type to optimize performance through whole-K prefetching, specifically for the hdim=128, hdim_v=128 configuration.
Changes:
- Added new pipeline enum
QRKSVS_WHOLEK_PREFETCHwith corresponding string mappings - Updated C++ pipeline implementation name field to match the new pipeline identifier
- Extended Python codegen to generate kernels for the new pipeline with specific constraints
- Added symbol mappings for the new pipeline in codegen infrastructure
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| block_fmha_pipeline_qr_ks_vs_whole_k_prefetch.hpp | Updated static name field to identify the pipeline implementation |
| block_fmha_pipeline_enum.hpp | Added new enum value and string mapping template specialization |
| fmha_fwd.py | Added pipeline tag to validation checks, tile size configuration, and generation logic with constraints |
| cpp_symbol_map.py | Added C++ class and enum mappings for the new pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…_whole_k_prefetch.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
poyenc
reviewed
Jan 15, 2026
| for tile, pipeline in itertools.product( | ||
| tiles, factory.get_pipelines(dtype, hdim, hdim_v, receipt, mask_impl) | ||
| ): | ||
| if pipeline.tag == "qr_wholek_prefetch" and ( |
Contributor
There was a problem hiding this comment.
Please move the check to the CompatibilityRuleFactoryGfx9
Refactor seqtune method for better readability.
poyenc
reviewed
Jan 15, 2026
| FmhaFwdPipeline( | ||
| "qr_wholek_prefetch", | ||
| "row", | ||
| "f", |
Contributor
There was a problem hiding this comment.
Why don't add padding for both of the seqlen_q & seqlen_k dimensions?
Collaborator
|
Hi @LJ-underdog , please make sure this thing compiles and passes tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered