update MHA CPP reademe - #4874
Open
minmengdie wants to merge 3 commits into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the C++ MHA benchmark documentation and benchmark hosts to better reflect current v3/asm feature support and performance reporting conventions.
Changes:
- Refresh
op_tests/cpp/mha/README.mdwith updated fwd/bwd v3 argument support tables, clarified mask semantics, and re-measured MI355X performance numbers. - Adjust backward benchmark FLOP accounting to apply the same masked-run FLOP convention used by the forward benchmark hosts.
- Minor comment text normalization in the v3 backward benchmark host.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| op_tests/cpp/mha/README.md | Updates usage guidance, supported-config tables, and performance result reporting notes/data. |
| op_tests/cpp/mha/benchmark_mha_bwd.cpp | Applies masked-run FLOP reporting adjustment for backward benchmarking. |
| op_tests/cpp/mha/benchmark_mha_bwd_v3.cpp | Same masked-run FLOP reporting adjustment for v3-only backward host; minor comment text updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+58
to
+60
| you can also call the executable `fwd.exe` to check whether the arguments are supported by the asm kernel with the `-is_v3_check=1` condition, try following commands: | ||
| ``` | ||
| ./benchmark_mha_fwd -prec=fp16 -b=1 -h=64 -d=128 -s=8192 -iperm=1 -operm=1 -mask=1 -lse=1 -fwd_v3=1 -mode=0 -kname=1 -v=0 -is_v3_check=1 | ||
| ./fwd.exe -prec=bf16 -b=1 -h=64 -d=128 -s=8192 -iperm=1 -operm=1 -mask=1 -lse=1 -fwd_v3=1 -mode=0 -kname=1 -v=0 -is_v3_check=1 |
Comment on lines
+338
to
+342
| // a masked run only computes roughly half the tiles | ||
| if(mask.type != mask_enum::no_mask) | ||
| { | ||
| flop /= 2; | ||
| } |
Comment on lines
+940
to
+944
| // a masked run only computes roughly half the tiles | ||
| if(mask.type != mask_enum::no_mask) | ||
| { | ||
| flop /= 2; | ||
| } |
Comment on lines
+129
to
+130
| A masked run only computes about half the tiles, so both hosts halve their FLOP | ||
| count for `mask != 0`; the `causal=1` rows are on that same convention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist