[ci] Expanding test filter options via PR label selection#3917
[ci] Expanding test filter options via PR label selection#3917
Conversation
geomin12
added
test:hipblaslt
| if "test_filter:" in label: | ||
| _, filter_type = label.split(":") | ||
| # If the filter type is not recognized, we ignore the label and keep the default test type | ||
| if filter_type not in ["smoke", "standard", "nightly", "full"]: |
There was a problem hiding this comment.
update labels for correct filtering! from test_filtering.md
| - `gfx...`: A build and test (if a test machine is available) is added to the CI matrix for the specified gfx family. (ex: `gfx120X`, `gfx950`) | ||
| - `test:...`: The full test will run only for the specified label and other labeled projects (ex: `test:rocthrust`, `test:hipblaslt`) | ||
| - `test_runner:...`: The CI will run tests on only custom test machines (ex: `test_runner:oem`) | ||
| - `test_filter:...`: The CI will run tests based on the specified filter (ex: `test_filter:nightly`). [test_filtering.md](./test_filtering.md) has additional information on allowed test filters. |
There was a problem hiding this comment.
update proper naming
dileepr1
left a comment
dileepr1
left a comment
There was a problem hiding this comment.
Added suggestions as per the new labels in test_filtering.md
| for matrix_row in linux_variants_output + windows_variants_output: | ||
| # If the "run-full-tests-only" flag is set for this family, we do not run tests if it is a smoke test type | ||
| if matrix_row.get("run-full-tests-only", False) and test_type == "smoke": | ||
| matrix_row["test-runs-on"] = "" |
There was a problem hiding this comment.
The clearing of this value should not occur when filter labels are set, so I think there is an issue with the sequencing between this for loop and the label logic.
There was a problem hiding this comment.
it does not! this is only relevant to gfx1151 windows machines for smoke tests (to limit capacity) and this is set in amdgpu_family_matrix.py
There was a problem hiding this comment.
Do you have a run where this was verified with a test case on gfx1151 windows and a label? The developer would want to run the specific label on the gfx1151 Windows runner for this example, or are we preventing this option?
as of now, we actually don't have any nightly_check_only_for_family families enabled. based on the logic though, it seems okay! |
geomin12
removed
test:hipblaslt
geomin12
added
test:hipblaslt
…Cm/TheRock into users/geomin12/extended-label
3 participants
In order to work with test standardization, we are expanding test filters.
Changes:
test_filter:nightly)is_schedulenow runs nightly testsCurrently, each component has different filters, so this is a CI update only, and we will update component shards / test filters accordingly once filters are ready per component
Working as test_filter:nightly is properly displayed https://github.com/ROCm/TheRock/actions/runs/22973838135?pr=3917