Skip to content

Move amdsmi from 'base/' folder and artifact to 'amdsmi' artifact in 'core/' #2072

@ScottTodd

Description

@ScottTodd

Per discussion at #2045 (comment), we would like to move the amdsmi subproject from its current location in https://github.com/ROCm/TheRock/tree/main/base to https://github.com/ROCm/TheRock/tree/main/core.

This will allow amdsmi to depend on the clang toolchain we build instead of the system compiler so ASan builds can be enabled. It will also unblock #2045 which moves therock-googletest (one of amdsmi's deps) to be configured after "base" (but still before "core"). See the include order here:

TheRock/CMakeLists.txt

Lines 459 to 464 in 2e9e168

# Add subdirectories in dependency DAG order (which happens to be semi-alpha:
# don't be fooled).
add_subdirectory(third-party)
add_subdirectory(base)
add_subdirectory(compiler)
add_subdirectory(core)

Quoting @stellaraccident from that thread:

If we do that, we should create an amdsmi artifact vs lumping it into "base". It needs to be its own and will need its own package, etc (so I think this was done as-is in error).

I'd love to further eliminate base/ entirely but we can get there eventually.

Some code to change:

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

TODO

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions