fwd support split batch #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaojiewang
reviewed
Jan 22, 2021
driver/igemm_fwd_gtc_driver.h
Outdated
| } | ||
|
|
||
| assert(splited_n * image_size < size_4g && n % splited_n == 0); | ||
| assert(n / splited_n < size_4g); |
Contributor
There was a problem hiding this comment.
What's the meaning of this assertion
Collaborator
Author
There was a problem hiding this comment.
This is to make sure n / splited_n can be hold in int type, since later on will return n / splited_n and the return type is int
Collaborator
Author
There was a problem hiding this comment.
But I guess this better removed, in case of confusing.
carlushuang
added a commit
that referenced
this pull request
Jan 29, 2021
* fwd support split batch * remove confusing assert * fix several >4G address type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is much simpler to support bigger tensor size