[bug][tests] Fix broken tests #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averinevg
changed the title
CAHEK7
approved these changes
Jul 22, 2024
junliume
approved these changes
Jul 24, 2024
atamazov
reviewed
Jul 30, 2024
Comment on lines
+1398
to
+1399
| // default datatype | ||
| test_drive_impl<Driver<float>>(name, std::move(as)); |
There was a problem hiding this comment.
Remove default datatype and fail when datatype is not set. Fix tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a number of tests do nothing. Most tests using
test_drive(), all tests usinginvoke_with_params()and all tests to which the default data type is not passed are broken. This PR fixes the launch of tests. These tests have not been verified to work correctly and are beyond the scope of this PR.