port:meson : mesonlib.darwin_get_object_archs only accepts str type #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this not an issue with the mainstream port? If it is, per my previous request for port:VLC, please file a trac ticket and put me on the CC list (you can use the "maintainers" field for that.
If it's an upstream (Meson) issue, please consider filing a ticket upstream too. That's MacPorts policy.
|
|
From what I can tell, this is fixed in newer versions of Meson but not in a release. |
|
So again this is something that does affect the main port as well...
|
|
My patch was accepted upstream. Could you include this patch until they make a new release? |
|
Sure, as soon as I get around to it!
|
|
Patch incorporated (still applies) even though there has been a new version 2 days ago?! |
|
No. The new version has my change. |
|
0.54.2 ? Then how come the patch (created from your commit) still applies? It's not one of those that applies infinitely...
|
|
I stand corrected. The 0.54.2 release is based on a commit from 225 commits ago. It does not contain my change. They seem to do releases like so:
|
|
OK, so they use release branches which presumably get bug fixes but not (all) new features.
Your patch seems to be a bugfix...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #52.
mesonlib.darwin_get_object_archsonly acceptsstrand does not convertPathobjects automatically.