[FWT-20] Out of the CR(H)IB and into the fire #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrorCheckingAndPosition # Conflicts: # CMakeLists.txt # include/dev/ADS8689IPWR.h # src/dev/ADS8689IPWR.cpp # targets/ADS8689IPWR/main.cpp # targets/CMakeLists.txt
Ethan-Caracoglia
requested review from
DiegoLHendrix,
XanBu,
aclowmclaughlin,
mjh9585 and
tmb5932
DiegoLHendrix
requested changes
May 9, 2025
|
Change the .github/workflows/cmake.yml file from |
aclowmclaughlin
requested changes
May 25, 2025
aclowmclaughlin
left a comment
aclowmclaughlin
left a comment
There was a problem hiding this comment.
This is really impressive work and the code is honestly really clean. I think 90% of everything I commented was simply just some like comments that could be added.
Only code change of significance is using a struct to contain the CAN message instead of an array.
mjh9585
requested changes
May 26, 2025
mjh9585
left a comment
mjh9585
left a comment
There was a problem hiding this comment.
Overall pretty good, just a few changes besides the ones mentioned. Please include the Jira Issue ID in the pull request name like the other.
Co-authored-by: Diego <119289719+DiegoLHendrix@users.noreply.github.com> Co-authored-by: Rue <61093955+aclowmclaughlin@users.noreply.github.com> Co-authored-by: Matthew Heller <69865851+mjh9585@users.noreply.github.com>
Ethan-Caracoglia
requested review from
DiegoLHendrix,
aclowmclaughlin and
mjh9585
…w there should be a straight line of dependence from the HIB to the ADC (HIB inherits RedundantADC inherits ADS8689IPWR)
…rrorCheckingAndPosition # Conflicts: # targets/REV3-HIB/main.cpp
Ethan-Caracoglia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Drivers for the ADS8689IPWR ADC sensors that get processed through SPI and packaged into a 5 byte CAN message that gets sent to the VCU giving throttle, brake, and error information.