Skip to content

Conversation

@mjmagee991
Copy link
Contributor

  • Added BQ reset pin
  • Added error LED pin
  • Added reset and error logic to take advantage of new pins

@mjmagee991 mjmagee991 requested a review from a team July 21, 2025 00:36
Copy link
Contributor

@aclowmclaughlin aclowmclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- is there a reason that the bq reset wasn't implemented initially?

Not important just curious.

@ActuallyTaylor
Copy link
Member

This has been validated on BMS v4 1 & 2. It should be good for merging now.

@ActuallyTaylor ActuallyTaylor marked this pull request as ready for review January 18, 2026 20:08
Copy link
Member

@ActuallyTaylor ActuallyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also runs well, I had no problems on the code end when validating the boards. Docs will come in a future PR.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Updated EVT-Core to the latest version, then renamed the DEV namespace to dev because it fits the new EVT core standard

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
@ActuallyTaylor
Copy link
Member

ActuallyTaylor commented Feb 6, 2026

I am working on analyzing were the increased FLASH usage is coming from. At the moment, it appears to be a problem with the CI using the newest arm tools, and our development using version 12.

I have also noticed that after updating EVT-Core it seems that even arm tools 12 creates binaries just too big.

It also seems like building for release, consistently adds ~1k extra flash over the debug releases...

Here are elf analysis of 3 build configurations (Debug, Release & CMAKE Build All). These are HTML files generated using an elf analysis tool: BMS Elf Analysis.zip

Originally, we were always using -Og which optomizas for debugging which increases binary size.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants