-
Notifications
You must be signed in to change notification settings - Fork 2
In V4 the BMS Doesn't Work Again #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mjmagee991
commented
Jul 21, 2025
- Added BQ reset pin
- Added error LED pin
- Added reset and error logic to take advantage of new pins
aclowmclaughlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- is there a reason that the bq reset wasn't implemented initially?
Not important just curious.
|
This has been validated on BMS v4 1 & 2. It should be good for merging now. |
ActuallyTaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Also runs well, I had no problems on the code end when validating the boards. Docs will come in a future PR.
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Updated EVT-Core to the latest version, then renamed the DEV namespace to dev because it fits the new EVT core standard Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
|
I am working on analyzing were the increased FLASH usage is coming from. At the moment, it appears to be a problem with the CI using the newest arm tools, and our development using version 12. I have also noticed that after updating EVT-Core it seems that even arm tools 12 creates binaries just too big. It also seems like building for release, consistently adds ~1k extra flash over the debug releases... Here are elf analysis of 3 build configurations (Debug, Release & CMAKE Build All). These are HTML files generated using an elf analysis tool: BMS Elf Analysis.zip |
Originally, we were always using -Og which optomizas for debugging which increases binary size. Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>