Skip to content

Reinstall custom event handlers when component updates #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2021
Merged

Reinstall custom event handlers when component updates #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b69646d
Reinstall custom event handlers when component updates
Johennes May 2, 2021
7306d30
Wrap custom event handlers in persisted functions reading from this.p…
Johennes May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions demo/src/Demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ class Demo extends React.Component {
};

render() {
let events = {
'focus': () => console.log('focus')
};
if (counter % 2 === 0) {
events['blur'] = () => console.log('blur')
}
return (
<div className="container container-narrow">
<div className="page-header">
Expand All @@ -68,6 +74,7 @@ class Demo extends React.Component {
label="Markdown Editor"
value={this.state.textValue1}
onChange={this.handleChange1}
events={events}
/>
<hr />
<SimpleMDEReact
Expand Down
44 changes: 31 additions & 13 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default class SimpleMDEEditor extends React.PureComponent<
private elementWrapperRef: HTMLDivElement | null;
private setElementWrapperRef: (element: HTMLDivElement) => void;
private keyChange = false;
private customEventCallbacks: SimpleMdeToCodemirror = {}

static defaultProps = {
events: {},
Expand Down Expand Up @@ -92,6 +93,8 @@ export default class SimpleMDEEditor extends React.PureComponent<
this.simpleMde!.value(this.props.value || "");
}
this.keyChange = false;

this.updateCustomEvents(this.props.events, prevProps.events);
}

componentWillUnmount() {
Expand Down Expand Up @@ -156,22 +159,37 @@ export default class SimpleMDEEditor extends React.PureComponent<
this.simpleMde.codemirror.on("change", this.eventWrapper);
this.simpleMde.codemirror.on("cursorActivity", this.getCursor);

const { events } = this.props;

// Handle custom events
events &&
Object.entries(events).forEach(([eventName, callback]) => {
if (eventName && callback) {
this.simpleMde &&
this.simpleMde.codemirror.on(
eventName as DOMEvent,
callback as any
);
}
});
this.updateCustomEvents(this.props.events)
}
};

updateCustomEvents = (events: SimpleMdeToCodemirror | undefined, prevEvents?: SimpleMdeToCodemirror | undefined) => {
prevEvents &&
Object.entries(prevEvents).forEach(([eventName, callback]) => {
if (eventName && callback && !events?.[eventName as CodemirrorEvents | DOMEvent]) {
this.simpleMde &&
this.simpleMde.codemirror.off(
eventName as DOMEvent,
this.customEventCallbacks[eventName as CodemirrorEvents | DOMEvent] as any
);
}
});
events &&
Object.entries(events).forEach(([eventName, callback]) => {
if (eventName && callback && !prevEvents?.[eventName as CodemirrorEvents | DOMEvent]) {
if (this.simpleMde) {
this.customEventCallbacks[eventName as CodemirrorEvents | DOMEvent] = (instance: any) => {
(this.props.events?.[eventName as CodemirrorEvents | DOMEvent] as any)?.(instance);
}
this.simpleMde.codemirror.on(
eventName as DOMEvent,
this.customEventCallbacks[eventName as CodemirrorEvents | DOMEvent] as any
);
}
}
});
};

getCursor = () => {
// https://codemirror.net/doc/manual.html#api_selection
if (this.props.getLineAndCursor) {
Expand Down