add protobuf-compiler as a requirement #83
Conversation
When using the nanopb package, a version of protoc is needed to generate .c and header files from the protobuf definitions. This adds protoc to riotdocker.
| @@ -8,3 +8,4 @@ ed25519==1.4 | |||
| cbor==1.0.0 | |||
| cryptography==2.6.1 | |||
| scapy>=2.4.3 | |||
| protobuf-compiler>=3.0.0 | |||
There was a problem hiding this comment.
travis fails, cannot find that package. https://pypi.org/project/protobuf-compiler/ shows v1.0.20 is current?
There was a problem hiding this comment.
Oh so these are Python modules - then this PR is of course wrong.
There was a problem hiding this comment.
Oh so these are Python modules - then this PR is of course wrong.
Now I lost confidence that you've actually tried to build the container yourself. 😉
There was a problem hiding this comment.
Github provides such a nice interface for making small edits to text files, I might have used just that…
|
Could we use the protoc ubuntu package? |
Absolutely! I thought this is what requirements.txt did - the package is called protobuf-compiler |
No, you'll need to add the package to one of the "apt-get" command lines. |
|
Closed in favor of #84 |
When using the nanopb package, a version of protoc is needed to generate .c and header files from the protobuf definitions.
This adds protoc to riotdocker.
Needed for RIOT-OS/RIOT#11565