C2Rust updates / fixes #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build failures after RIOT-OS#189 show that the test coverage is insufficient to catch C2Rust breakage; this mitigates it by building an example that pulls in much more code.
|
Hmpf. It's not helping, but not breaking things either :-/ |
This uses a branch of the LLVM PR <immunant/c2rust#693> which fixes C2Rust's issue <immunant/c2rust#692>. Both have been preexisting for a while, but became critical when switching over to the current LLVM version.
|
It's now not only updating to latest upstream, but to a branch that fixes the concrete issue upstream. I'd leave this as two commits because these can well be understood separately, and that the first passed CI on its own (even though that was only because RISCV was untested at that time; now it should not pass any more thanks to RIOT-OS/RIOT#18654) is good separate information. |
|
LGTM. Let's wait if the hifive1 rust code is built now |
kaspar030
approved these changes
Sep 27, 2022
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is used for investigating failures encountered after merging #189, in which C2Rust errs internally. Upstream might already have solved it.
This builds on #209.