Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting script for accuracy timer benchmark #98

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

pokgak
Copy link
Contributor

@pokgak pokgak commented Mar 20, 2021

This PR adds the plotting script for accuracy timer benchmarks. I also included the fix to the resulting HTML file to convert <br> tags in the Plotly output to <br />.

This script is only for the accuracy timer benchmark, for now, more coming.

@pokgak pokgak requested a review from MrKevinWeiss March 20, 2021 17:22
@pokgak pokgak force-pushed the add-plotting-scripts-accuracy branch from 6a7f46f to 5a3c423 Compare March 20, 2021 18:12
@MrKevinWeiss
Copy link
Collaborator

Do I need something to view the graphs after downloading the .html? I can see the data is there just nothing is being rendered on my browser. I assume this will be a function of the new HiL website?

If @ozfox says it is OK then I am fine.

@pokgak
Copy link
Contributor Author

pokgak commented Mar 21, 2021

The HTML file output from the pipeline is not a complete HTML file, only meant to be included using XSLT. However, you can remove the flag --for-ci from the command in robot-html in Makefile.include to get a full HTML that can be opened in a browser.

@pokgak
Copy link
Contributor Author

pokgak commented Mar 21, 2021

@ozfox you might want to check if the HTML output from this PR can be used with XSLT.

@MrKevinWeiss
Copy link
Collaborator

Hmm, we can break that out late if we need control from the make level. All good on my end.

@pokgak
Copy link
Contributor Author

pokgak commented Mar 24, 2021

Ping @ozfox?

@ozfox
Copy link
Contributor

ozfox commented Mar 25, 2021

@pokgak Accuracy plots look great! Works as expected..

Copy link
Collaborator

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MrKevinWeiss MrKevinWeiss merged commit 9b932c9 into RIOT-OS:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants