Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/cc26x0/gpio: use gpio_irq feature #9999

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

haukepetersen
Copy link
Contributor

See #9992

@miri64 miri64 added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers labels Sep 27, 2018
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the same way as I did #10008:

As far as I can tell (and checked with colordiff -u <(git show | grep "^-" | sed 's/^-//g') <(git show | grep "^+" | sed 's/^+//g')) this just moves and ifdefs some code around. After a local rebase to include #9981 I also was able to build this with tests/periph_gpio both with periph_gpio_irq manually added or removed to FEATURES_OPTIONAL. Without periph_gpio_irq the binary is significantly smaller with this PR than in master.

I used cc2650-launchpad as a board for the compile tests.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 9, 2018
@miri64 miri64 merged commit f6ef19a into RIOT-OS:master Oct 9, 2018
@miri64 miri64 deleted the fix_gpioirq_cc26x0 branch October 9, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants