Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/ezr32wg/gpio: use gpio_irq feature #9993

Merged
merged 1 commit into from
Oct 9, 2018
Merged

cpu/ezr32wg/gpio: use gpio_irq feature #9993

merged 1 commit into from
Oct 9, 2018

Conversation

haukepetersen
Copy link
Contributor

See #9845

This was referenced Sep 21, 2018
Merged
Closed
@miri64 miri64 added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers labels Sep 27, 2018
miri64
miri64 approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the same way as I did #10008:

As far as I can tell (and checked with colordiff -u <(git show | grep "^-" | sed 's/^-//g') <(git show | grep "^+" | sed 's/^+//g')) this just moves and ifdefs some code around. After a local rebase to include #9981 I also was able to build this with tests/periph_gpio both with periph_gpio_irq manually added or removed to FEATURES_OPTIONAL. Without periph_gpio_irq the binary is significantly smaller with this PR than in master.

I used slwstk6220a as a board for the compile tests.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 9, 2018
@kYc0o
Copy link
Contributor

kYc0o commented Oct 9, 2018

Shouldn't we test that IRQ still work on the hardware?

@miri64
Copy link
Member

miri64 commented Oct 9, 2018

Shouldn't we test that IRQ still work on the hardware?

If it doesn't it shouldn't be caused by this PR. Because as I said: I checked that the code is still the same (which is expected for a scope fix).

@miri64
Copy link
Member

miri64 commented Oct 9, 2018

Ping @kYc0o was this explanation enough for you?

@kYc0o
Copy link
Contributor

kYc0o commented Oct 9, 2018

Yes, thanks. I'd anyways say that testing is always better (we don't have an automated test for this yet) so it would have been the opportunity. But that's ok, I believe you it doesn't harm.

@kYc0o kYc0o merged commit 5d9b980 into RIOT-OS:master Oct 9, 2018
@miri64 miri64 deleted the fix_gpioirq_ezr32wg branch October 9, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haukepetersen @kYc0o @miri64