Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iotlab-support: use iotlab command to check credentials #9586

Merged
merged 1 commit into from
Aug 2, 2018
Merged

iotlab-support: use iotlab command to check credentials #9586

merged 1 commit into from
Aug 2, 2018

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 17, 2018

Contribution description

Since the iotlab-term target uses tmux error messages are not really printed, so it took me a while to find out why at some sites this target wasn't working for me anymore.

If the IoT-LAB password was changed, just checking if .iotlabrc exists isn't enough, so I use iotlab-experiment to check if I'm logged in properly to prompt the password input in case I'm not.

Issues/PRs references

None

@miri64
iotlab-support: use iotlab command to check credentials
ad65aad 
Since the `iotlab-term` target uses `tmux` error messages are not really
printed, so it took me a while to find out why at some sites this target
wasn't working for me anymore.

If the IoT-LAB password was changed, just checking if `.iotlabrc`
exists isn't enough, so I use `iotlab-experiment` to check if I'm logged
in properly to prompt the password input in case I'm not.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tools Area: Supplementary tools Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Jul 17, 2018
@miri64 miri64 added this to the Release 2018.07 milestone Jul 17, 2018
@miri64 miri64 requested review from cladmi, cgundogan and aabadie July 17, 2018 11:07
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 17, 2018
cgundogan
cgundogan approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. ACK.

@cgundogan cgundogan merged commit 36529e3 into RIOT-OS:master Aug 2, 2018
@miri64 miri64 deleted the dist/fix/iotlab-term branch August 2, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

@cladmi cladmi Awaiting requested review from cladmi

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @cgundogan @cladmi