dist/tools: update EDBG version

[dylad]

Contribution description

This PR updates EDBG version of RIOT to the lastest.
I had a lot of troubles when playing with low power modes or DPLL/DFLL on SAM0 based board. Most of the time, the board was stuck in a unrecoverable state for EDBG and I had to erase the flash using Atmel Studio (switch back to windows to unbrick the board...)
The lastest version of EDBG get rid of this problem as I can now erase/reflash the board in all situations. No need to use Atmel Studio anymore to unbrick a board !

Issues/PRs references

None

[cladmi]

Let's see if murdock can handle it already.

[dylad]

@cladmi Looks like Murdock is happy :)

[cladmi]

It looks like murdock does not use the compiled edbg and uses a local installation:

make: Entering directory '/tmp/dwq.0.3981599149433197/4ceadfbccb6700af35ecc065b126a1aa/tests/gnrc_ndp'

/usr/local/bin/edbg --serial ATML2127031800002130 --serial ATML2127031800002130 -t atmel_cm0p -b -e -v -p -f /tmp/dwq.0.3981599149433197/4ceadfbccb6700af35ecc065b126a1aa/tests/gnrc_ndp/bin/samr21-xpro/tests_gnrc_ndp.bin
Debugger: ATMEL EDBG CMSIS-DAP ATML2127031800002130 01.1A.00FB (S)
...

For testing the new version I needed to make edbg rebuild by removing it from dist/tools/edbg.

The correct solution to correctly rebuild edbg is to add the Makefile dependency:
(it should even be there for all tools).

diff --git a/makefiles/tools/targets.inc.mk b/makefiles/tools/targets.inc.mk
index 352f146..74f1de6 100644
--- a/makefiles/tools/targets.inc.mk
+++ b/makefiles/tools/targets.inc.mk
@@ -12,7 +12,7 @@ $(RIOTTOOLS)/bossa/bossac:
        @make -C $(RIOTTOOLS)/bossa
        @echo "[INFO] bossac binary successfully build!"
 
-$(RIOTTOOLS)/edbg/edbg:
+$(RIOTTOOLS)/edbg/edbg: $(RIOTTOOLS)/edbg/Makefile
        @echo "[INFO] edbg binary not found - building it from source now"
        CC= CFLAGS= make -C $(RIOTTOOLS)/edbg
        @echo "[INFO] edbg binary successfully build!"

With this change, when flashing from your PR edbg is correctly rebuild and flashes.
You could add it in a separate commit.

Propagating to other tools should be done in another PR.

[dylad]

Thanks @cladmi, I'll update it soon.

[cladmi]

@dylad I would prefer if you could add the explanation of why you need the update in the commit message body.

I was thinking about adding the new version number/changelog too but it looks like there is nothing like this in the edbg repository :D

[dylad]

@cladmi I'll edit the first commit msg too then.

[dylad]

@cladmi do you like the changes ?

[cladmi]

It's good for me on ubuntu 16.04. I tested with:

git checkout master; rm -f dist/tools/edbg/edbg; make -C examples/hello-world/ BOARD=samr21-xpro flash

Then go the PR and try flashing again, edbg is correctly rebuild before flashing.

git checkout pr/9502/update_EDBG_version ; make -C examples/hello-world/ BOARD=samr21-xpro flash
# edbg is rebuild

After testing you may need to redo rm -f dist/tools/edbg/edbg before switching back to master to remove the "new" version until this is merged.

I would just like to get it tested on other setups too:

• arch linux @jcarrano
• gentoo @bergzand
• murdock when forced to used edbg
• mac @kYc0o

[bergzand]

Confirmed that EDBG is rebuild on my setup after switching from master to this branch.

[kaspar030]

you could add a temporary commit that disables EDBG override from local version (I think thats in makefiles/tools/edbg.inc.mk), set the run-tests-on-ci label, then trigger murdock. that should make the samr21-xpro raspis re-build edbg from the updated source and use it to flash the tests.

[cladmi]

I pushed a commit that should do it.

[kaspar030]

It seems to fail because there's no libudev on the worker. I'll install that manually...

[kaspar030]

Did so, an I'm watching the worker, the flashing works from the in-tree compiled version.

[cladmi]

@kaspar030 Thanks for testing this

[cladmi]

@kYc0o does it work on mac ?

[cladmi]

Maybe @smling you can test: #9502 (comment)

[kYc0o]

Tested (OS X and Linux) ACK.

However, it might need the removal of the last commit + squash.

[cladmi]

Please remove my two last commits (I don't want to push force to your branch).

[dylad]

@cladmi Sorry for the delay, this is done.

[cladmi]

20 minutes after my message is not "delay" :p

Murdock is failing on the same shell tests as it often does. I removed CI: run tests and you can merge when it's done if I forget to.