boards/arduino-nano: Support for the Arduino Nano #9499

maribu · 2018-07-04T20:39:33Z

Contribution description

This PR adds support for the Arduino Nano. The Arduino Nano board is the cheapest member of the Arduino family and used the same MCU as the Arduino Uno. It differs in the form factor (the Nano is much smaller), it uses an integrated FT232RL TTL adapter instead of an ATmega16u2 to provide access to the serial console via USB, and it uses a different bootloader (which occupies 2 KiB of the 32 KiB flash instead of 0.5 KiB occupied on the Arduino Uno). This commit mostly copy pastes code from the Arduino Uno.

Testing procedure

Check the provided documentation
Check if make BOARD=arduino-nano flash and make BOARD=arduino-nano term works for examples/hello-world

As this shares most code with the Arduino UNO, no huge troubles are expected.

Issues/PRs references

None

maribu · 2018-07-04T20:40:40Z

TODO: Is the serial device on Linux really /dev/ttyUSB0 for Arduino Nano? (I own a board that should be mostly compatible to the Arduino Nano and looks similar to it, but it is not actually an Arduino at all.) Maybe someone can help me with that?

ZetaR60 · 2018-07-04T21:36:13Z

@maribu I think you need to find someone with an Arduino Nano in order to complete this PR. Your similar board is not enough because we have no guarantee that it will translate over to the Arduino Nano.

maribu · 2018-07-05T04:11:25Z

@ZetaR60: All Arduino clones I saw so far use the same PIN layout, the same MCU, and the same bootloader. Some use a different USB to UART chip, which is a minor inconvenience on Linux machines. E.g. the device file of official Arduino UNO will be located at /dev/ttyACM0, while most clones will have it named /dev/ttyUSB0. Apart from that and the missing Arduino logo the clones are identical to the real boards.

This PR uses /dev/ttyUSB0, as this almost accepted PR used it also. But maybe that PR was never tested on an official board...

maribu · 2018-07-05T04:15:00Z

@SemjonKerner, @sebastiankliem, @smlng: You were active in the old and apparently dead Arduino Nano PR. Did you test that PR on original hardware? If so, could test this PR, also?

ZetaR60 · 2018-07-05T04:47:12Z

@maribu The code would probably end up okay, but in my opinion should still be tested at least once on an original. I think it is fine to go ahead and work on the PR, as it shouldn't be too hard to find someone that has one.

maribu · 2018-07-05T08:18:59Z

@ZetaR60: I totally agree that this should be tested on an original Arduino. I just wanted to point out, that apart from the PORT value on Linux it is unlikely that something wont work.

maribu · 2018-07-05T08:24:01Z

Another issue: Currently this PR contains no C code or header files. As result, Doxygen documentation for this board is available. May creating a board.h that contains the documentation and an #include to the Arduino Uno's board.h would be better?

Or maybe the whole folder should be dropped and instead some Makefile magic like

ifeq($(BOARD),arduino-nano)
  export PROGRAMMER_SPEED ?= 57600
  BOARD := arduino-uno
endif

should be used?

kYc0o · 2018-07-05T09:58:59Z

Please look at #9130, I'd like to avoid more code duplication by adding more atmega based boards. I know the PR seems big but I'll try to split it once they allow me to squash.

maribu · 2018-07-05T10:18:25Z

@kYc0o: I'm not sure if I got you. Are you suggesting to wait until #9130 is merged, than rebase this PR against it?

Actually, I'm not even sure if this PR is really required. Updating the wiki page to tell users to just use treat the Nano as an Arduino Uno with a different programmer speed might be just as fine. E.g. like this:

make BOARD=arduino-uno PROGRAMMER_SPEED=57600 flash
make BOARD=arduino-uno term

sebastiankliem · 2018-07-05T14:15:34Z

I did not test the code on original hardware. Unfortunately, I do not have any capacity to work on this further.

kYc0o · 2018-07-05T16:30:57Z

@kYc0o: I'm not sure if I got you. Are you suggesting to wait until #9130 is merged, than rebase this PR against it?

I'd say yes, wait to unify and clean up the code. Then we continue to add more boards.

For the sake of consistency, I think the board folder is needed, along with the required (minimal) files. After #9130 is merged this should be 2 or 3 files max.

maribu · 2019-03-03T18:55:04Z

Maybe @miri64 might want to take a look, as I shamelessly stole all code in this PR from her ;-)

In the meantime I verified that /dev/ttyUSB0 is indeed the correct path even for non-clones, as the Nano does not use the ATmega32u2 for USB connectivity but a USB TTL adapter. According to the doc of that adapter dev/ttyUSBx is correct on Linux.

miri64 · 2019-03-07T10:17:58Z

Again: not my domain (I only reviewed #7306 because I happened to have it in my drawer ;-)).

kYc0o

Untested ACK.

There are basically no changes to the base code, however I'd like someone to test it. Unfortunately I don't have the hardware.

If it doesn't get tested you might merge it before the soft feature freeze.

kYc0o · 2019-03-07T13:31:35Z

You need to blacklist the board on some tests before Murdock is happy.

Removing approval so we don't accidentally merge this PR untested ;-)

SemjonWilke · 2019-03-07T19:06:47Z

I believe I have a nano at home. If so I can test this PR by beginning of the next week.

SemjonWilke · 2019-03-12T21:01:18Z

My "nano" is indeed a clone. The PR works out of the box, but sadly I couldn't flash some tests and examples, like examples/default and tests/saul, for a lack of memory. It came back with section '.data' is not within region 'data' and some more overflow messages. EDIT: I expected that, but still hoped, it could fit though.

I did nothing but install the compiler, and make examples/hello-world, tests/shell, and two or three tests/driver_*.
If you want me to test anything specific, pls summon me again.

maribu · 2019-03-12T21:09:51Z

but sadly I couldn't flash some tests and examples, like examples/default and tests/saul,

Thats expexted, this doesn't work for the Uno either. Thanks for testing!

kYc0o · 2019-03-14T10:59:30Z

Everything seems ok but (again...) the board needs to be marked as insufficient memory...

The Arduino Nano board is the cheapest member of the Arduino family and used the same MCU as the Arduino Uno. It differs in the form factor (the Nano is much smaller), it uses an integrated FT232RL TTL adapter instead of an ATmega16u2 to provide access to the serial console via USB, and it uses a different bootloader (which occupies 2 KiB of the 32 KiB flash instead of 0.5 KiB occupied on the Arduino Uno). This commit mostly copy pastes code from the Arduino Uno.

Added arduino-nano to BOARD_INSUFFICIENT_MEMORY/BOARD_BLACKLIST following suit of how arduino-uno is marked, as arduino-nano is mostly an Uno in a different form factor.

maribu · 2019-03-14T14:53:12Z

So, after updating 141 Makefiles and adding the Nano BOARD_INSUFFICIENT_MEMORY or to BOARDS_BLACKLISTED, everything is green now.

@kYc0o: Mind to merge before anyone touches one of the 141 Makefiles? Otherwise I would need to rebase again and solve the merge conflicts.

kYc0o

ACK.

kYc0o · 2019-03-14T15:04:45Z

Oops, the latest commit message has "Upadte" twice, but it's rather a detail. Thanks for your contribution @maribu !

maribu · 2019-03-14T15:10:55Z

Oops, the latest commit message has "Upadte" twice

That kind of error is really typical for me... *faceplam*

maribu mentioned this pull request Jul 4, 2018

boards/arduino-nano: port arduino nano board #7540

Closed

miri64 removed the Area: arduino API Area: Arduino wrapper API label Sep 1, 2018

maribu added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 16, 2018

maribu force-pushed the arduino-nano branch from f25fb87 to 58e312e Compare March 3, 2019 18:49

maribu removed Community: help wanted The contributors require help from other members of the community State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 3, 2019

maribu requested review from miri64, kYc0o and ZetaR60 March 3, 2019 18:53

maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 3, 2019

miri64 removed their request for review March 7, 2019 10:17

kYc0o previously approved these changes Mar 7, 2019

View reviewed changes

miri64 added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines labels Mar 7, 2019

maribu added 2 commits March 14, 2019 13:54

examples: Updated BOARD_INSUFFICIENT_MEMORY

e14bea1

Added arduino-nano to BOARD_INSUFFICIENT_MEMORY/BOARD_BLACKLIST following suit of how arduino-uno is marked, as arduino-nano is mostly an Uno in a different form factor.

maribu force-pushed the arduino-nano branch from 467993e to 56c46e6 Compare March 14, 2019 12:59

tests: Updated Updated BOARD_INSUFFICIENT_MEMORY

0e90e61

Added arduino-nano to BOARD_INSUFFICIENT_MEMORY/BOARD_BLACKLIST following suit of how arduino-uno is marked, as arduino-nano is mostly an Uno in a different form factor.

maribu force-pushed the arduino-nano branch from 6bf668b to 0e90e61 Compare March 14, 2019 14:40

kYc0o approved these changes Mar 14, 2019

View reviewed changes

kYc0o merged commit cff2b5e into RIOT-OS:master Mar 14, 2019

maribu deleted the arduino-nano branch March 14, 2019 15:11

danpetry added this to the Release 2019.04 milestone Apr 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards/arduino-nano: Support for the Arduino Nano #9499

boards/arduino-nano: Support for the Arduino Nano #9499

maribu commented Jul 4, 2018 •

edited

Loading

maribu commented Jul 4, 2018

ZetaR60 commented Jul 4, 2018

maribu commented Jul 5, 2018

maribu commented Jul 5, 2018

ZetaR60 commented Jul 5, 2018

maribu commented Jul 5, 2018

maribu commented Jul 5, 2018 •

edited

Loading

kYc0o commented Jul 5, 2018

maribu commented Jul 5, 2018

sebastiankliem commented Jul 5, 2018

kYc0o commented Jul 5, 2018

maribu commented Mar 3, 2019

miri64 commented Mar 7, 2019

kYc0o left a comment

kYc0o commented Mar 7, 2019

SemjonWilke commented Mar 7, 2019

SemjonWilke commented Mar 12, 2019 •

edited

Loading

maribu commented Mar 12, 2019

kYc0o commented Mar 14, 2019

maribu commented Mar 14, 2019

kYc0o left a comment

kYc0o commented Mar 14, 2019

maribu commented Mar 14, 2019 •

edited

Loading

boards/arduino-nano: Support for the Arduino Nano #9499

boards/arduino-nano: Support for the Arduino Nano #9499

Conversation

maribu commented Jul 4, 2018 • edited Loading

Contribution description

Testing procedure

Issues/PRs references

maribu commented Jul 4, 2018

ZetaR60 commented Jul 4, 2018

maribu commented Jul 5, 2018

maribu commented Jul 5, 2018

ZetaR60 commented Jul 5, 2018

maribu commented Jul 5, 2018

maribu commented Jul 5, 2018 • edited Loading

kYc0o commented Jul 5, 2018

maribu commented Jul 5, 2018

sebastiankliem commented Jul 5, 2018

kYc0o commented Jul 5, 2018

maribu commented Mar 3, 2019

miri64 commented Mar 7, 2019

kYc0o left a comment

Choose a reason for hiding this comment

kYc0o commented Mar 7, 2019

SemjonWilke commented Mar 7, 2019

SemjonWilke commented Mar 12, 2019 • edited Loading

maribu commented Mar 12, 2019

kYc0o commented Mar 14, 2019

maribu commented Mar 14, 2019

kYc0o left a comment

Choose a reason for hiding this comment

kYc0o commented Mar 14, 2019

maribu commented Mar 14, 2019 • edited Loading

maribu commented Jul 4, 2018 •

edited

Loading

maribu commented Jul 5, 2018 •

edited

Loading

SemjonWilke commented Mar 12, 2019 •

edited

Loading

maribu commented Mar 14, 2019 •

edited

Loading