Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/cortexm: explicitly set -march=armv6s-m for crotexm0(plus) #9122

Merged
merged 1 commit into from
May 14, 2018
Merged

cpu/cortexm: explicitly set -march=armv6s-m for crotexm0(plus) #9122

merged 1 commit into from
May 14, 2018

Conversation

kaspar030
Copy link
Contributor

Contribution description

Works around a regression in gcc 8.1.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85606.

Issues/PRs references

Fixes #9120.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels May 11, 2018
@kaspar030 kaspar030 requested a review from cgundogan May 11, 2018 21:10
cgundogan
cgundogan approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Murdock with an older gcc is also still satisfied. ACK

@cgundogan cgundogan merged commit db754c6 into RIOT-OS:master May 14, 2018
@kaspar030 kaspar030 deleted the fix_cortexm0_gcc81 branch May 14, 2018 09:33
@cladmi cladmi added this to the Release 2018.07 milestone Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2018.07
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @cgundogan @cladmi