Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/cc2538: remove obsolete periph file guard #8955

Merged
merged 1 commit into from
May 14, 2018
Merged

cpu/cc2538: remove obsolete periph file guard #8955

merged 1 commit into from
May 14, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 16, 2018

Contribution description

This PR partially addresses #7981 with cc2538 cpus

Issues/PRs references

#7981

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 16, 2018
@aabadie aabadie requested a review from smlng April 16, 2018 08:08
@haukepetersen haukepetersen mentioned this pull request Apr 16, 2018
Closed
46 tasks
@kaspar030 kaspar030 changed the title cpu/cc2538: remove useless periph file guard cpu/cc2538: remove obsolete periph file guard Apr 16, 2018
smlng
smlng approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested with remote.

@bergzand
Copy link
Member

ping @smlng, Is there a reason why this is not yet merged? :)

@aabadie
Copy link
Contributor Author

aabadie commented May 14, 2018

Is there a reason why this is not yet merged?

I don't see any. So let's merge !

@aabadie aabadie merged commit ecb2e47 into RIOT-OS:master May 14, 2018
@aabadie aabadie deleted the pr/cpu/guard_cc2538 branch June 1, 2018 18:58
@cladmi cladmi modified the milestone: Release 2018.07 Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlng smlng smlng approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.07
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @bergzand @smlng @cladmi