Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: update features list + line length cleanup #8551

Merged
merged 2 commits into from
Aug 1, 2018
Merged

README: update features list + line length cleanup #8551

merged 2 commits into from
Aug 1, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 13, 2018

Contribution description

This PR update the RIOT readme file:

  • it adds Sigfox and LoRaWAN to the list of features (I think it's important to mention them here)
  • it splits some lines that exceeds the maximum 80 characters length

Issues/PRs references

None

@aabadie aabadie added Area: doc Area: Documentation Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 13, 2018
basilfx
basilfx reviewed Feb 13, 2018
View reviewed changes
README.md
[quickstart guide](http://doc.riot-os.org/index.html#the-quickest-start) or
try this
[tutorial](https://github.com/RIOT-OS/Tutorials/blob/master/README.md).
For specific toolchain installation, follow instructions in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... instructions on the ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already written like that. My english knowledge is not good enough to know what's best/valid.

@aabadie aabadie added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Feb 27, 2018
PeterKietzmann
PeterKietzmann approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for this change even though I' not convinced about the content selection for this README in general.

@PeterKietzmann PeterKietzmann merged commit 0230c2c into RIOT-OS:master Aug 1, 2018
@aabadie aabadie deleted the pr/readme_features branch September 23, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basilfx basilfx basilfx left review comments

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@emmanuelsearch emmanuelsearch Awaiting requested review from emmanuelsearch

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @basilfx @PeterKietzmann