-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: murdock: Replace hardcoded path by bindir variable #8194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
.murdock
Outdated
@@ -99,7 +101,7 @@ compile() { | |||
test -d ${BINDIR} && echo "-- build directory size: $(du -sh ${BINDIR} | cut -f1)" | |||
|
|||
# cleanup | |||
rm -Rf build | |||
rm -rf ${BINDIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a test
statement above. You should move the rm
up there and concatenate with &&
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made it a full if...then
, otherwise that line would become a bit long.
Much better now! Please squash. |
@cgundogan after some tests I realized that |
yes I know. But why try to delete something that you are 100% sure of not being present? (: |
Well, now it is checked twice, once by the bash script and once by the |
And in the case the directory does not exist, it checks only once, not twice (; |
8f3665d
to
1a83c20
Compare
I'm not going to make a huge point out of this, squashed |
Replaces the two
rm -rf build
to use theBINDIR
variable.