Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: murdock: fix output error on missing builddir after failed build #8193

Merged
merged 1 commit into from
Dec 1, 2017
Merged

ci: murdock: fix output error on missing builddir after failed build #8193

merged 1 commit into from
Dec 1, 2017

Conversation

kaspar030
Copy link
Contributor

Small check prevents "du" error like here.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: CI Area: Continuous Integration of RIOT components Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 1, 2017
@kaspar030 kaspar030 requested a review from smlng December 1, 2017 10:58
@kaspar030
Copy link
Contributor Author

For reference: link in PR description shows this:

-- running on worker riot-ci.inet.haw-hamburg.de thread 1, build number 93651.
make: Entering directory '/tmp/dwq.0.06810601776083991/7dbf2f045046408bb9f4b884350ce874/tests/openthread'
/tmp/dwq.0.06810601776083991/7dbf2f045046408bb9f4b884350ce874/tests/openthread/../../Makefile.include:181: *** An application name must be specified as APPLICATION..  Stop.
make: Leaving directory '/tmp/dwq.0.06810601776083991/7dbf2f045046408bb9f4b884350ce874/tests/openthread'
du: cannot access '/tmp/dwq.0.06810601776083991/7dbf2f045046408bb9f4b884350ce874/build': No such file or directory
-- build directory size:

This PR fixes the error and broken output in the last two lines.

bergzand
bergzand approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

smlng
smlng approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bergzand bergzand merged commit c3d2bf9 into RIOT-OS:master Dec 1, 2017
@kaspar030 kaspar030 deleted the fix_errorbuild_missing_builddir branch May 11, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

@smlng smlng smlng approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @bergzand @smlng