Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/kw2xrf: fix fall through #8192

Merged
merged 1 commit into from
Dec 1, 2017
Merged

drivers/kw2xrf: fix fall through #8192

merged 1 commit into from
Dec 1, 2017

Conversation

pyropeter
Copy link
Contributor

This was made visible by #7919. Broke build on GCC 7.2.

Probably a bug.

@pyropeter
drivers/kw2xrf: fix fall through
19f6544 
This was made visible by RIOT-OS#7919. Broke build on GCC 7.2.

Probably a bug.
cgundogan
cgundogan approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks quite buggy. ACK.

@cgundogan cgundogan added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 1, 2017
@cgundogan cgundogan added this to the Release 2018.01 milestone Dec 1, 2017
smlng
smlng approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@smlng
Copy link
Member

smlng commented Dec 1, 2017

okay the compiler helped, but anyway 😉

@cgundogan cgundogan merged commit 1f18233 into RIOT-OS:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

@smlng smlng smlng approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.
3 participants
@pyropeter @smlng @cgundogan