Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/xtimer_usleep_short: fix non set APPLICATION variable #8187

Merged
merged 1 commit into from
Nov 30, 2017
Merged

tests/xtimer_usleep_short: fix non set APPLICATION variable #8187

merged 1 commit into from
Nov 30, 2017

Conversation

jthacker
Copy link
Contributor

test/xtimer_usleep_short does not set APPLICATION in the Makefile. This results in binaries named test_.elf
This patch sets APPLICATION appropriately.

aabadie
aabadie approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Can you change the commit comment to tests/xtimer_usleep_short: fix non set APPLICATION variable ?

Then it will be good to go

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tests Area: tests and testing framework labels Nov 30, 2017
@jthacker jthacker force-pushed the pr_test_xtimer_usleep_short_missing_application branch from 1e5bcc1 to 052beea Compare November 30, 2017 17:54
@cgundogan cgundogan changed the title Fixes APPLICATION not set for tests/xtimer_usleep_short tests/xtimer_usleep_short: fix non set APPLICATION variable Nov 30, 2017
@cgundogan cgundogan merged commit a7e7f03 into RIOT-OS:master Nov 30, 2017
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.
3 participants
@jthacker @aabadie @cgundogan