Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: tests: optimize for NIB #8185

Merged
merged 2 commits into from
Nov 30, 2017

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 30, 2017

Apparently, I forgot to adapt gnrc_minimal for the NIB (GNRC_IPV6_NC_SIZE does not exist anymore). Reasoning for the values:

  • GNRC_IPV6_NIB_NUMOF same as GNRC_IPV6_NC_SIZE
  • GNRC_IPV6_NIB_OFFL_NUMOF be able to configure at least one route to a sub-net.

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation GNRC Area: network Area: Networking labels Nov 30, 2017
@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

Scrapes off ~700B of RAM, at least on Cortex-M0.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 30, 2017
@cladmi
Copy link
Contributor

cladmi commented Nov 30, 2017

I see there is also still GNRC_IPV6_NC_SIZE in tests/gnrc_sock_dns/Makefile

@cladmi cladmi self-requested a review November 30, 2017 16:12
@cladmi
Copy link
Contributor

cladmi commented Nov 30, 2017

Could you add your the explanation of the GNRC_IPV6_NIB_OFFL_NUMOF value in the commit message body ? It helps when git blaming in the future :)

I would assume the reason we are using 1 here is to allow compiling on smaller boards, right ?

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

I would assume the reason we are using 1 here is to allow compiling on smaller boards, right ?

Well the name of the example is minimal, and having only one forwarding entry, is the most minimal configuration that still makes sense.

On your other comments will address, just need to finish something else first.

@cladmi
Copy link
Contributor

cladmi commented Nov 30, 2017

Well the name of the example is minimal, and having only one forwarding entry, is the most minimal configuration that still makes sense.

Yeah I figured it out after re-reading the name of the example

@miri64 miri64 changed the title examples: gnrc_minimal: optimize for NIB examples: tests: optimize for NIB Nov 30, 2017
@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

Comments addressed. The BOARD_INSUFFIENT_MEMORY change is just for testing. I might revert parts of it ;-).

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

\o/ I reached my optimization goal! We can fit GNRC on a chronos now ^^.

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

(even in router configuration oO)

Copy link
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, just needs rebase for murdock

@miri64 miri64 force-pushed the examples/fix/opt-for-nib branch from 8dd4268 to 60d62ee Compare November 30, 2017 18:51
@miri64 miri64 force-pushed the examples/fix/opt-for-nib branch from 60d62ee to 2b543dd Compare November 30, 2017 18:51
@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

Squashed and rebased.

@bergzand bergzand merged commit cc521fd into RIOT-OS:master Nov 30, 2017
@miri64 miri64 deleted the examples/fix/opt-for-nib branch November 30, 2017 19:13
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants