Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_netdev: remove remaining files and references #8180

Merged
merged 1 commit into from
Nov 30, 2017
Merged

gnrc_netdev: remove remaining files and references #8180

merged 1 commit into from
Nov 30, 2017

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 29, 2017

Somehow, these files were forgotten in my big cleanup in #7925. This fixes that.

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation GNRC Area: network Area: Networking labels Nov 29, 2017
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 29, 2017
@miri64 miri64 force-pushed the gnrc_netdev/cleanup/rm branch 3 times, most recently from 574f6bf to 3e5f249 Compare November 29, 2017 17:59
@miri64 miri64 mentioned this pull request Nov 29, 2017
Merged
2 tasks
@miri64 miri64 changed the title gnrc_netdev: remove remaining files gnrc_netdev: remove remaining files and references Nov 29, 2017
@bergzand
Copy link
Member

Looks like Murdock discovered some includes that were missing from some tests but pulled in by the gnrc_netdev headers.

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

Fixed

@bergzand
Copy link
Member

@miri64 From the remaining errors, it looks like the openthread package first needs a bit of reworked glue to get rid of gnrc_netdev.

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

@miri64 From the remaining errors, it looks like the openthread package first needs a bit of reworked glue to get rid of gnrc_netdev.

WTF???!!? What has openthread to do with GNRC???!

@bergzand
Copy link
Member

bergzand commented Nov 30, 2017 •
edited
Loading

Whoa, don't shoot the messenger.

Here is the guilty line, but from what I see is that that should be a "net/netdev.h", but I didn't test it.

Edit: noticed #8183 :)

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017 •
edited
Loading

Whoa, don't shoot the messenger.

Never said I would ;-). More like stomping off and blindly shouting at the people responsible (me included because I didn't catch it in #7082 either).

@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 30, 2017
@bergzand
Copy link
Member

Is it possible to also remove the gnrc_netdev modules from Makefile.dep?

@bergzand
Copy link
Member

Pre-rebase ACK btw.

@miri64 miri64 force-pushed the gnrc_netdev/cleanup/rm branch from 99bb041 to c635877 Compare November 30, 2017 17:38
@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

Is it possible to also remove the gnrc_netdev modules from Makefile.dep?

Done and rebased.

@bergzand
Copy link
Member

A quick grep shows quite a few remaining references to either gnrc_netdev as comment (netdev radio drivers) or gnrc_netdev_default` as a module. Do you want to have those removed here too?

Most notable references found to gnrc_netdev so far:

Most notably so far

  • sys/Makefile:64
  • drivers/Makefile.dep:57

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

gnrc_netdev_default is supposed to stay (it pulls in GNRC and the default netdev for a board. Will remove the other references.

@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

Done.

@bergzand
Copy link
Member

Ack, squash please.

@miri64
gnrc_netdev: remove remaining files and references
5a0e9bc 
Somehow, these files were forgotten in my big cleanup in RIOT-OS#7925. This
fixes that.
@miri64 miri64 force-pushed the gnrc_netdev/cleanup/rm branch from d82f3ce to 5a0e9bc Compare November 30, 2017 18:49
@miri64
Copy link
Member Author

miri64 commented Nov 30, 2017

Squashed.

@miri64 miri64 removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels Nov 30, 2017
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 30, 2017
@bergzand bergzand merged commit 0d85186 into RIOT-OS:master Nov 30, 2017
@miri64 miri64 deleted the gnrc_netdev/cleanup/rm branch November 30, 2017 19:12
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

Assignees

@bergzand bergzand

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @bergzand @aabadie