-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: wakaama: Fix and update wakaama package to version fe48d45 #8148
Conversation
There also is this related issue #8106 |
If I understand what you did (trying to read diff between two patch files is tricky):
When rebased on the last master with -Wall -Wextra -Werror I have no error when building. If you could change the commit message, to prepend the directory, like the older commit in this directory: I will ACK after rewording the commit message. @florian-jean: can you check this too ? It could be used as a base commit for your added functionalities |
For maintainers: can be tested with
|
* Fix the not updated `PKG_TEMP_DIR` to `PKG_BUILDDIR` * Bump the version * Make the patches apply and fix warnings/errors
@cladmi I did just that and added a few more fixes while I was at it. I forgot to test compilation with the different operation modes. I've tested the new changes as follows: Client with bootstrap mode: Client without bootstrap mode: Server mode: Bootstrap-server mode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not compiling package now compiles, ACK.
Did not tested the functionality but its an improvement anyway.
Agreed |
This pull request updates the Eclipse wakaama package to a more current version from the main repository.
I've tested this change by compiling
examples/hello-world/
withUSEPKG += wakaama
for severalBOARD
s (native, bluepill, stm32f4discovery, ...), since there is no actual test for this package. I also only tested whether it would compile but no functionality (yet).This does not compile when
size_t
<= 16 bit , like withBOARD=arduino-uno
, but that shouldn't work with the current version either (if that ever worked, since there's an error in the makefile and the patches don't apply for me).In the future I would like add an example application for this and/or a module that could provide default objects for LwM2M and bindings for supported hardware.