Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: wakaama: Fix and update wakaama package to version fe48d45 #8148

Merged
merged 1 commit into from
Nov 30, 2017
Merged

pkg: wakaama: Fix and update wakaama package to version fe48d45 #8148

merged 1 commit into from
Nov 30, 2017

Conversation

moenoel
Copy link
Contributor

@moenoel moenoel commented Nov 27, 2017

This pull request updates the Eclipse wakaama package to a more current version from the main repository.

I've tested this change by compiling examples/hello-world/ with USEPKG += wakaama for several BOARDs (native, bluepill, stm32f4discovery, ...), since there is no actual test for this package. I also only tested whether it would compile but no functionality (yet).

This does not compile when size_t <= 16 bit , like with BOARD=arduino-uno, but that shouldn't work with the current version either (if that ever worked, since there's an error in the makefile and the patches don't apply for me).

In the future I would like add an example application for this and/or a module that could provide default objects for LwM2M and bindings for supported hardware.

@cladmi
Copy link
Contributor

cladmi commented Nov 28, 2017

There also is this related issue #8106
I will look at both.

@cladmi
Copy link
Contributor

cladmi commented Nov 29, 2017

If I understand what you did (trying to read diff between two patch files is tricky):

  • Fix the not updated PKG_TEMP_DIR to PKG_BUILDDIR
  • Bump the version
  • Make the patches apply and fix warnings/errors

When rebased on the last master with -Wall -Wextra -Werror I have no error when building.
It may not work, but its better than not building.

If you could change the commit message, to prepend the directory, like the older commit in this directory: pkg: wakaama: Fix and update wakaama package to version XYZ and in the body the steps of the update (== my description or your corrected one) it would be perfect.

I will ACK after rewording the commit message.

@florian-jean: can you check this too ? It could be used as a base commit for your added functionalities

@florian-jean
Copy link

florian-jean commented Nov 29, 2017

@cladmi

Yes I would gladly use this as base commit.
In fact I already bump in the lattest version of wakkama and modified all the core and examples files in order to compile the without the WERROR=0 in the repo I updated in #8106 but a few files still need to be fixed

@cladmi
Copy link
Contributor

cladmi commented Nov 29, 2017

For maintainers: can be tested with

USEPKG+=wakaama make -C examples/hello-world
USEPKG+=wakaama make -C examples/hello-world BOARD=samr21-xpro

@moenoel moenoel changed the title Update wakaama package pkg: wakaama: Fix and update wakaama package to version fe48d45 Nov 29, 2017
* Fix the not updated `PKG_TEMP_DIR` to `PKG_BUILDDIR`
* Bump the version
* Make the patches apply and fix warnings/errors
@moenoel
Copy link
Contributor Author

moenoel commented Nov 29, 2017

@cladmi I did just that and added a few more fixes while I was at it.

I forgot to test compilation with the different operation modes. I've tested the new changes as follows:

Client with bootstrap mode:
USEPKG+=wakaama CFLAGS+="-DLWM2M_CLIENT_MODE -DLWM2M_BOOTSTRAP" make -C examples/hello-world

Client without bootstrap mode:
USEPKG+=wakaama CFLAGS+=-DLWM2M_CLIENT_MODE make -C examples/hello-world

Server mode:
USEPKG+=wakaama CFLAGS+=-DLWM2M_SERVER_MODE make -C examples/hello-world

Bootstrap-server mode:
USEPKG+=wakaama CFLAGS+=-DLWM2M_BOOTSTRAP_SERVER_MODE make -C examples/hello-world

@cladmi cladmi self-assigned this Nov 30, 2017
@cladmi cladmi added Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 30, 2017
Copy link
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not compiling package now compiles, ACK.

Did not tested the functionality but its an improvement anyway.

@miri64
Copy link
Member

miri64 commented Nov 30, 2017

Agreed

@miri64 miri64 merged commit 70d2991 into RIOT-OS:master Nov 30, 2017
@moenoel moenoel deleted the update-wakaama branch November 30, 2017 13:42
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants