Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: fixed indention in (drivers/)Makefile.dep #7573

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

haukepetersen
Copy link
Contributor

This is getting an annoying, repetitive task, once again fixing the indention in our dep Makefiles.

@haukepetersen haukepetersen added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 6, 2017
@haukepetersen haukepetersen added this to the Release 2017.10 milestone Sep 6, 2017
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes here but the include Makefiles (in drivers) need to be addressed as well if we agree on 2 spaces indendations for Makefile.

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, don't know how to fix the annoyance part though. Script is not possible, because something like the following is still possible and can not be written with spaces:

my-target: my-deps
ifeq (1,$(MYVAR))
	cmd1 # this line has to start with a tab
endif
	cmd2

@miri64 miri64 merged commit 7f7c2f1 into RIOT-OS:master Sep 6, 2017
@miri64
Copy link
Member

miri64 commented Sep 6, 2017

if we agree on 2 spaces indendations for Makefile.

This is a convention for years now.

@miri64
Copy link
Member

miri64 commented Sep 6, 2017

(but only for var definition ifs. It is not possible to start a target definition without a tab)

@haukepetersen haukepetersen deleted the fix_makedep_indention branch September 6, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants