Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spelling: s/initialisation/initialization/ #7566

Merged
merged 1 commit into from
Sep 5, 2017
Merged

spelling: s/initialisation/initialization/ #7566

merged 1 commit into from
Sep 5, 2017

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Sep 5, 2017

Follow-up of #7565. Just thought of that.

@aabadie aabadie added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Sep 5, 2017
@aabadie aabadie added this to the Release 2017.10 milestone Sep 5, 2017
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 5, 2017
miri64
miri64 approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but we should give some guidelines, if we prefer US or UK spelling in doc and act accordingly ;-)

@miri64 miri64 merged commit 9ea9b71 into RIOT-OS:master Sep 5, 2017
@smlng
Copy link
Member

smlng commented Sep 5, 2017

we should give some guidelines, if we prefer US or UK spelling

IMHO both is proper English and should we really (really?) bother with (or need to care about) that? I mean, do we want to end up correcting developers/users who prefer British over American English or vice-versa over and over?

Btw. as RIOT originates from Europe maybe we should embrace British English 😉

@miri64
Copy link
Member

miri64 commented Sep 5, 2017 •
edited
Loading

IMHO both is proper English and should we really (really?) bother with (or need to care about) that? I mean, do we want to end up correcting developers/users who prefer British over American English or vice-versa over and over?

Agreed.

Btw. as RIOT originates from Europe maybe we should embrace British English 😉

I don't have any particular preference.

@aabadie
Copy link
Contributor Author

aabadie commented Sep 5, 2017

Initialize is recommended by Oxford English Dictionnary. It seems there's no consensus within the UK.

@miri64 miri64 mentioned this pull request Sep 5, 2017
Merged
@kYc0o
Copy link
Contributor

kYc0o commented Sep 5, 2017

I think the problem is not that now you change it, since in upcoming PRs anyways people will spell it as they want (me for instance I'll continue to write "initialisation").

I'm not against having merged this but it won't change anything in the future, and both spellings are correct.

@OlegHahm
Copy link
Member

OlegHahm commented Oct 3, 2017 •
edited
Loading

Btw. as RIOT originates from Europe maybe we should embrace British English

Well, not so sure this is a valid argument any more after they left Europe. ;-)

@smlng
Copy link
Member

smlng commented Oct 4, 2017

@OlegHahm referring to #brexit, I guess? Then, I wouldn't deem recent political decisions higher than long lasting historic (and obvious geographic) ties/bonds 😉 Plus, (IMHO) they have better 🍻 than the US.

@aabadie aabadie deleted the typo_initialisation branch February 26, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@miri64 miri64

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2017.10
Development

Successfully merging this pull request may close these issues.
5 participants
@aabadie @smlng @miri64 @kYc0o @OlegHahm