rpl: make parent lifetime consistent with other timers #6935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlng
added
Type: enhancement
smlng
force-pushed
the
net/rpl/fix_parent_timer
branch
from
d2c9988 to
5c48d58
Compare
BytesGalore
suggested changes
Apr 25, 2017
sys/net/gnrc/routing/rpl/gnrc_rpl.c
Outdated
| } | ||
| parent->lifetime -= GNRC_RPL_LIFETIME_UPDATE_STEP; | ||
| } | ||
| else { | ||
| gnrc_rpl_dodag_t *dodag = parent->dodag; | ||
| gnrc_rpl_parent_remove(parent); | ||
| gnrc_rpl_parent_update(dodag, NULL); | ||
| continue; |
There was a problem hiding this comment.
the continue is not necessary anymore, plz remove
then ACK from my side
smlng
force-pushed
the
net/rpl/fix_parent_timer
branch
from
5c48d58 to
fbb9e07
Compare
|
@BytesGalore addressed! |
BytesGalore
approved these changes
Apr 25, 2017
smlng
added
the
CI: ready for build
smlng
force-pushed
the
net/rpl/fix_parent_timer
branch
from
fbb9e07 to
41c43fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6229