doc: utilize smartmenus

[miri64]

As of version 1.8.12 Doxygen uses smartmenus for the navbar on top. Our design should do so as well (while also supporting <1.8.12 Doxygen output).

Fixes #6910.

[jnohlgard]

Will test this after the weekend.

[jnohlgard]

Fixes the problem for me on Doxygen 1.8.13.
However, was the doc/doxygen/index.html file added by mistake?

[jnohlgard]

Discovered a minor issue, the arrows for expanding the tree in the side bar are overlapped by the text.

[miri64]

Fixes the problem for me on Doxygen 1.8.13.
However, was the doc/doxygen/index.html file added by mistake?

Fixed

Discovered a minor issue, the arrows for expanding the tree in the side bar are overlapped by the text.

Can you send me the html files again? I did not observe this issue. :-/

[jnohlgard]

I managed to locate the problem. It seems like the design update is switching the box model from content-box to border-box, which causes the 16px width arrow span to include the padding, which is set by navtree.js to (16px * indent_level). If we can switch back to the default content-box model then everything should be OK again, I think. I'm not well versed in modern web technologies so I couldn't find where to change it, but there are mentions of border-box when I git grep the doc/doxygen/src tree.

[jnohlgard]

Found some more info:
http://stackoverflow.com/questions/18854259/why-did-bootstrap-3-switch-to-box-sizing-border-box

Bootstrap is simply incompatible with Doxygen without patching templates/html/navtree.js in the Doxygen sources.

The navtree looks fine on my side when removing the box-sizing specifiers in bootstrap.min.js, but I don't know if it will have other side-effects on the layout when the dimensions in CSS are not as expected.

[miri64]

Actually I already fixed that for the current version at doc.riot.org (that's what this is about). Please just send me your sources and I'll fix that again.

[miri64]

Alternatively, have a look with your browser's "Inspect" function which selector sets the this?

[jnohlgard]

The selector is * found in bootstrap.min.js

[miri64]

Then let's try this with a compiled result again, if this isn't a problem for you.

[miri64]

(which browser are you using?)

[kaspar030]

whats the state here?

[miri64]

I need @gebart's compiled doc to fix the issue he pointed out.

[kaspar030]

Would it make sense to fix this for .04?

[miri64]

It does not affect the build doc at doc.riot-os.org at the moment, and even then is just about some broken styling, so I wouldn't give it that much priority.

[miri64]

(+ there is no release-based version of doc.riot-os.org anyway).

[jnohlgard]

replacing the selector line at https://github.com/RIOT-OS/RIOT/blob/master/doc/doxygen/src/css/riot.css#L92-L95 by

#nav-tree img, #nav-tree span {

seem to fix it on my side.

[miri64]

Rebased and fixed in riot.less (and recompiled riot.css)

[miri64]

Seems like there was a difference in here ;-)

[jnohlgard]

ACK

[miri64]

Squashd

[jnohlgard]

Running './dist/tools/whitespacecheck/check.sh master' x
Command output:

	doc/doxygen/src/css/jquery.smartmenus.bootstrap.css:31: space before tab in indent.
	+ 	border-style: solid;
	doc/doxygen/src/css/jquery.smartmenus.bootstrap.css:123: new blank line at EOF.
	doc/doxygen/src/js/jquery.smartmenus.bootstrap.min.js:4: new blank line at EOF.
	doc/doxygen/src/js/jquery.smartmenus.min.js:4: new blank line at EOF.
	doc/doxygen/src/js/menu.js:30: trailing whitespace.
	+    /* code adapted from original menu.js of Doxygen, but made 
	ERROR: This change introduces new whitespace errors

[miri64]

Fixed and amended immediately

[jnohlgard]

Still one white space error according to Murdock

[miri64]

Fixed and amended

[jnohlgard]

Murdock is fine, go!