gnrc_ndp: do not add new neighbors as TENTATIVE on 6LR #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
|
I'm not sure it is totally part of the other problem. At least this will avoid an address to be removed from ncache. Since there is not a lot of way to test this, I would ack and merge as soon as CI is done. |
miri64
added
the
CI: ready for build
|
CIs are happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 6775 describes in the section of processing RS to set the AR type of an address on
TENTATIVE. Problem: since we don't implement multi-hop DAD at the moment the address stays this type and is removed after the timeout. I suspect this to be part of the problem in #5790.If it does not fix this issue not, this is still a bug, since setting a state timeout for a NCE that is not properly resolved is faulty behavior. This behavior is labeled as MAY in the RFC, so removing it should be fine.