make: allow some ordering of package builds

[kaspar030]

Previously, packages would be built in alphabetical ordering and possibly in parallel.
This PR adds an option to build certain packages prior to others and adds them as dependencies.

Fixes #6022.

[kaspar030]

Hm, does anyone know how to get rid of this:

make: Circular /home/kaspar/src/riot/examples/nanocoap_server/bin/nrf52dk/nordic_softdevice_ble.a <- /home/kaspar/src/riot/examples/nanocoap_server/bin
/nrf52dk/nordic_softdevice_ble.a dependency dropped.

[miri64]

Hm, does anyone know how to get rid of this:

Break the circle ;-).

[kaspar030]

Break the circle ;-).

Yeah. It is caused by making all packages depend on all buildfirst packages. How can I filter the dependencies so the prerequisite doesn't include the target?

[miri64]

mhh… using $(filter-out, ..., ...) but I don't see where you should apply that.

[cgundogan]

Doesn't this ordering problem persist for packages in USEPKG_BUILDFIRST with the proposed solution?

[kaspar030]

Yup. I consider this a quickfix for the problem at hand. I'd prefer full dependencies, or split download/patch and compile steps. But they'd be a lot more work to implement...

[kaspar030]

ping

This fixes everything for nrf52dk which uses a package name > nordic_softdevice_ble...

[miri64]

Is this fixed?

Hm, does anyone know how to get rid of this:

make: Circular /home/kaspar/src/riot/examples/nanocoap_server/bin/nrf52dk/nordic_softdevice_ble.a <- /home/kaspar/src/riot/examples/nanocoap_server/bin
/nrf52dk/nordic_softdevice_ble.a dependency dropped.

[kaspar030]

Is this fixed?

No, but I don't know how to fix it, and it is purely cosmetic.

[miri64]

Is this fixed?

No, but I don't know how to fix it, and it is purely cosmetic.

I argue that it is not just cosmetic if there is a circular dependency. That's a conceptual issue.

[kaspar030]

I argue that it is not just cosmetic if there is a circular dependency. That's a conceptual issue.

In general I totally agree. In this specific case the circular dependency is spotted where defined and removed by make, in this one line, and there's no easy way to remove the circular dependency beforehand. It also doesn't harm in any way other than the notice.

[miri64]

In general I totally agree. In this specific case the circular dependency is spotted where defined and removed by make, in this one line, and there's no easy way to remove the circular dependency beforehand. It also doesn't harm in any way other than the notice.

Here is one easy (not sure of ugly ^^") way:

diff --git a/Makefile.include b/Makefile.include
index fa9e85b..238320b 100644
--- a/Makefile.include
+++ b/Makefile.include
@@ -303,8 +303,13 @@ USEMODULE_INCLUDES_ = $(shell echo $(USEMODULE_INCLUDES) | tr ' ' '\n' | awk '!a

 INCLUDES += $(USEMODULE_INCLUDES_:%=-I%)

-.PHONY: $(USEPKG:%=${BINDIR}/%.a)
-$(USEPKG:%=${BINDIR}/%.a): $(RIOTBUILD_CONFIG_HEADER_C) $(USEPKG_BUILDFIRST:%=${BINDIR}/%.a)
+USEPKG_BUILDLATER := $(filter-out $(USEPKG_BUILDFIRST),$(USEPKG))
+.PHONY: $(USEPKG_BUILDLATER:%=${BINDIR}/%.a)
+$(USEPKG_BUILDLATER:%=${BINDIR}/%.a): $(RIOTBUILD_CONFIG_HEADER_C) $(USEPKG_BUILDFIRST:%=${BINDIR}/%.a)
+       @mkdir -p ${BINDIR}
+       "$(MAKE)" -C $(RIOTPKG)/$(patsubst ${BINDIR}/%.a,%,$@)
+
+$(USEPKG_BUILDFIRST:%=${BINDIR}/%.a): $(RIOTBUILD_CONFIG_HEADER_C)
        @mkdir -p ${BINDIR}
        "$(MAKE)" -C $(RIOTPKG)/$(patsubst ${BINDIR}/%.a,%,$@)

[miri64]

No activity for over half a year. Closing as memo for now. Reopen if you disagree.