Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtls: Temporary fix example for #6022 #6032

Merged
merged 1 commit into from
Nov 1, 2016
Merged

dtls: Temporary fix example for #6022 #6032

merged 1 commit into from
Nov 1, 2016

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 31, 2016 •
edited
Loading

Seems like DTLS is also affected by #6022 (signal @rfuentess)

@miri64
dtls: Temporary fix example for RIOT-OS#6022
afe5ebe 
Seems like DTLS is also affected
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Oct 31, 2016
@miri64 miri64 added this to the Release 2016.10 milestone Oct 31, 2016
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 31, 2016
This was referenced Nov 1, 2016
Merged
Merged
Merged
@PeterKietzmann
Copy link
Member

Well, I have no problems building examples/dtls-echo for nrf52dk without this PR. Did you expect that?

@miri64
Copy link
Member Author

miri64 commented Nov 1, 2016

It is weird, sometimes it works, sometimes not see Murdocks build of #5598 and #5419 e.g.

@PeterKietzmann
Copy link
Member

Hmm, I don't know what to do here. Compiled tests/dtls-echo with make nrf52dk as well as make buildtest. Everything has passed. My compiler is: gcc version 5.2.1

@kaspar030???

PeterKietzmann
PeterKietzmann approved these changes Nov 1, 2016
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fine if it fixes Murdock right now. Please don't forget to remove the comment in the Makefile once this is fixed. ACK

@PeterKietzmann PeterKietzmann merged commit 1c337b1 into RIOT-OS:master Nov 1, 2016
@miri64 miri64 deleted the dtls/fix/blacklist-nrf52dk branch November 1, 2016 12:42
@miri64
Copy link
Member Author

miri64 commented Nov 1, 2016

Same goes for the nanocoap stuff ;-)

@miri64 miri64 mentioned this pull request Nov 1, 2016
Merged
@rfuentess
Copy link
Contributor

@miri64 then DTLS and nanocoap are giving similar issues (Random compilation success for murdok) to those in #6009 ?

@miri64
Copy link
Member Author

miri64 commented Nov 1, 2016

No, I did just saw this with DTLS so far. The nanocoap issue (#6022) was a different one that's already fixed (see #6032).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

Assignees

@haukepetersen haukepetersen

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.10
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @PeterKietzmann @rfuentess @haukepetersen