Skip to content

ndp: add missing header include #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2016
Merged

ndp: add missing header include #5864

merged 1 commit into from
Sep 23, 2016
+1 −0

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Sep 23, 2016 •
edited
Loading

sys/include/net/ndp.h uses IPv6 addresses in NDP message type definitions but up
until now the according header wasn't included.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Sep 23, 2016
@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 23, 2016
OlegHahm
OlegHahm approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@OlegHahm OlegHahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@OlegHahm
Copy link
Member

But please fix the commit message before merging. 😉

@miri64
Copy link
Member Author

miri64 commented Sep 23, 2016

In which way?

@OlegHahm
Copy link
Member

The part "...but up until now the according header." seems to be incomplete to me.

@miri64
ndp: add missing header include
9dc4023 
sys/include/net/ndp.h uses IPv6 addresses in NDP message type definitions but up
until now the according header wasn't included.
@miri64 miri64 force-pushed the ndp/fix/incl-header branch from cf612aa to 9dc4023 Compare September 23, 2016 18:23
@miri64
Copy link
Member Author

miri64 commented Sep 23, 2016

Ah. Fixed.

@OlegHahm
Copy link
Member

The linebreak looks strange, but I assume that's a GitHub UI issue?

@miri64
Copy link
Member Author

miri64 commented Sep 23, 2016

Well that depends on how you see it. My vim is configured to break at 80 chars as per coding conventions. I assume GitHub breaks at the more common 72 ;-).

@OlegHahm
Copy link
Member

OlegHahm commented Sep 23, 2016 •
edited
Loading

"more common 72" - huh? Why and where is this more common? Couldn't find a single reference here for programming: https://en.wikipedia.org/wiki/Characters_per_line

Hm, well, probably commit messages don't really count as programming. ;-) Maybe you should teach your vim to handle different file types differently. ;-)

@OlegHahm OlegHahm merged commit 9088883 into RIOT-OS:master Sep 23, 2016
@miri64 miri64 deleted the ndp/fix/incl-header branch September 23, 2016 19:06
@miri64 miri64 added this to the Release 2016.10 milestone Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegHahm OlegHahm

Assignees

@OlegHahm OlegHahm

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miri64 @OlegHahm