Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: sync Tutorials folder into vbox #5846

Merged
merged 1 commit into from
Sep 16, 2016

Conversation

cgundogan
Copy link
Member

This addition to the Vagrantfile syncs the parent folder of RIOT into the vbox machine with the name Tutorials, which is necessary for the RIOT Tutorial [1] to work. Otherwise, it is always necessary to clone the tutorials folder seperately into the vbox machine.

How does this work:
The Vagrantfile defines a primary RIOT machine, which is booted and ssh'ed into with vagrant up and vagrant ssh. To boot the tutorials machine definition and ssh into it, you must use vagrant up tutorials and vagrant ssh tutorials. This tutorials machine will sync the RIOT folder to $HOME and also the Tutorials folder, which is the parent folder if cloned from [1].

[1] https://github.com/RIOT-OS/Tutorials

@cgundogan cgundogan added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tools Area: Supplementary tools labels Sep 16, 2016
@cgundogan cgundogan force-pushed the pr/vagrantfile_tutorial branch from 0000366 to c767f27 Compare September 16, 2016 14:32
@cgundogan
Copy link
Member Author

amended a small fix (wrote tutorial instead of tutorials) and added a name for the machine

@smlng
Copy link
Member

smlng commented Sep 16, 2016

this basically works, ACK from myside

Two minor issues:

  1. following error is raised when another RIOT VM runs parallel to tutorials:
Vagrant cannot forward the specified ports on this VM, since they
would collide with some other application that is already listening
on these ports. The forwarded port to 4242 is already in use
on the host machine.

Should separate network config with differing ports here.

  1. if someone runs vagrant up tutorials in RIOT root dir (not from tutorials), then this would expose any upper folder (../) of RIOTBASE into the VM.

Though I understand the latter to be desired/needed for the tutorials.

@cgundogan
Copy link
Member Author

@smlng good hint, regarding the ports, let's try to fix that in a follow-up PR

@smlng
Copy link
Member

smlng commented Sep 16, 2016

@cgundogan hope to see this one soon 😁 ACK and GO then.

@smlng smlng merged commit 0d901c4 into RIOT-OS:master Sep 16, 2016
@miri64 miri64 added this to the Release 2016.10 milestone Oct 17, 2016
@cgundogan cgundogan deleted the pr/vagrantfile_tutorial branch October 26, 2016 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants