-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: use -std=c99 as default #5824
Conversation
NACK because the code is full of GNU extensions ... |
Apart from the ones fixed by this PR, where? |
E.g. |
"full of" is a little bit exaggerated.
The former is used in "kernel_defines.h", but guarded. Keep in mind that gcc sets "GNUC" also for "-std=c99". The latter is used for the x86 port. That could still compile with "-std=gnu99", like this PR sets for native. Don't you think it is desirable to not use the extensions where not needed? This PR is about setting the default... |
Though I like the GNU extensions, because IMO they allow you to write more readable code in some cases, I won't get a rage fit if this PR gets adopted. And finding two core developers who like this "restriction" should not be too difficult, I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK because the code is full of GNU extensions ...
I guess Murdock proved me wrong. I'm OK with this change. ACK.
6b720f7
to
1f70e65
Compare
|
@ALL Any opinions on this? |
I'll leave this open for two more days and then merge if noone complains. |
@kaspar030 second thoughts? |
Previously, the fallback was "gnu99", but we don't allow GNU extensions by convention.