Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/cc2538: Remove superfluous mutex lock #5804

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

aeneby
Copy link
Member

@aeneby aeneby commented Sep 3, 2016

AFAICT, these mutex locks are unnecessary and simply introduce delays. The sequential nature of RIOT's packet handling and the TX_ACTIVE wait in send() should be enough to ensure exclusivity.

@OlegHahm OlegHahm added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers labels Sep 3, 2016
@OlegHahm OlegHahm added this to the Release 2016.10 milestone Sep 3, 2016
@alignan
Copy link
Contributor

alignan commented Sep 15, 2016

Fine by me 👍

@alignan alignan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 15, 2016
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Tested basic communication between samr21-xpro and remote-reva with success

@PeterKietzmann
Copy link
Member

ACK and go

@PeterKietzmann PeterKietzmann merged commit 436ff13 into RIOT-OS:master Sep 26, 2016
@aeneby aeneby deleted the no_mutex_lock branch September 26, 2016 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants