Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: initial support of ST Nucleo f446 #5706

Merged
merged 2 commits into from
Sep 29, 2016

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 29, 2016

This is a first attempt for supporting the ST Nucleo f446 board. There's room for improvement (mainly code factorization with other similar boards).

I only tested the port with the hello-world example for the moment and it worked.

@kaspar030 kaspar030 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jul 29, 2016
@aabadie
Copy link
Contributor Author

aabadie commented Jul 29, 2016

For the record, I added the saul support for the user LED and button. I put it in nucleo-common so it should be available for all supported nucleo.

@OlegHahm OlegHahm added the Platform: ARM Platform: This PR/issue effects ARM-based platforms label Jul 31, 2016
@PeterKietzmann PeterKietzmann self-assigned this Aug 9, 2016
@PeterKietzmann PeterKietzmann added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Aug 9, 2016
@aabadie
Copy link
Contributor Author

aabadie commented Sep 16, 2016

That would be good if someone could test this one. And also the other related PRs (#5709, #4949, #5798)

Copy link

@gryor gryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Nucleo F446RE and this works.

@aabadie
Copy link
Contributor Author

aabadie commented Sep 23, 2016

Thanks for testing @wilhelmmatilainen. It's strange that your approved review doesn't have any effect on the status of this PR.
Let's wait for @PeterKietzmann review and then it can be merged.

@PeterKietzmann
Copy link
Member

@aabadie code-wise the PR looks fine to me. @wilhelmmatilainen what did you test? @ALL who else has this board available?

@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 28, 2016
@PeterKietzmann
Copy link
Member

@aabadie please add the vendor header to the doxygen exclude patterns here

@aabadie
Copy link
Contributor Author

aabadie commented Sep 28, 2016

please add the vendor header to the doxygen exclude patterns

Good catch ! Just pushed the change.

@gryor
Copy link

gryor commented Sep 28, 2016

Upload, blinking led, serial. I think it would be fine to resolve problems
as they occur. For the beginning it would be nice to have this as a base.

2016-09-28 16:20 GMT+03:00 Alexandre Abadie notifications@github.com:

please add the vendor header to the doxygen exclude patterns

Good catch ! Just pushed the change.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5706 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPLFFmx_QjVvnvbTmpj1G0wvMAp6wxvks5qummIgaJpZM4JX-Xq
.

@aabadie
Copy link
Contributor Author

aabadie commented Sep 29, 2016

@PeterKietzmann, I added a link in the supported platform page.

Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PeterKietzmann PeterKietzmann merged commit d33786d into RIOT-OS:master Sep 29, 2016
@aabadie aabadie deleted the nucleo_f446 branch October 3, 2016 15:42
@aabadie aabadie added this to the Release 2016.10 milestone Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants