cpu/atmega2560: reworked UART (from #5026)

[kYc0o]

Takes #5026 and adds small fixes.

[kYc0o]

@aabadie today it's gonna be the day? ;)

[kaspar030]

@kYc0o is that copyright correct? (shouldn't INRIA?)

[kYc0o]

Actually this code comes from Hauke, I didn't modify anything on this so I think is ok

[kaspar030]

ok, perfect! :)

[aabadie]

@kYc0o, code changes looks good to me but I don't have a mega2560 for testing.

[kYc0o]

@adjih doesn't have one? Or @jia200x ?

[kaspar030]

Ive got one but little time. would basic shell testing confirm that this is working?

-----Original Message-----
From: kYc0o notifications@github.com
To: RIOT-OS/RIOT RIOT@noreply.github.com
Cc: Kaspar Schleiser kaspar@schleiser.de, Comment comment@noreply.github.com
Sent: Do., 16 Juni 2016 17:06
Subject: Re: [RIOT-OS/RIOT] cpu/atmega2560: reworked UART (from #5026) (#5537)

@adjih doesn't have one? Or @jia200x ?

---

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#5537 (comment)

[kYc0o]

Somehow yes, but of you can run the test 'periph_uart' and check for the second uart it would be ok

[aabadie]

@kYc0o, yes @adjih have some but they are used in custom setup for IoT-Lab.

[aabadie]

@kYc0o, I just gave it a try. The UART0 works.

But I tried to configure another UART and didn't succeed. I based my work by simply adding the bare minimum for UART communication in the hello example:

• in the Makefile, I added:

USEMODULE += xtimer
USEMODULE += periph_uart  # should be FEATURES_REQUIRED += periph_uart

• in the main.c, I added:

#include "periph/uart.h"
#include "xtimer.h"

and, after the initial printf:

uart_init(2, 115200, NULL, (void*)NULL);
    for (;;) {
        uart_write(2, (uint8_t*)"test\n", 5);
        xtimer_sleep(1);
    }

but then the build fails with the error:

avr-gcc: error: <path_to_src>/RIOT/examples/hello-world/bin/arduino-mega2560/periph_uart.a: No such file or directory
<path_to_src>/RIOT/Makefile.include:259: recipe for target 'all' failed
make: *** [all] Error 1

Is it me or is there something broken ? Do all UARTs be supported on this board ?

[aabadie]

Ok, actually it was me, sorry 😕
I used the wrong Makefile option for periph_uart... (it should be FEATURES_REQUIRED)...

So for me it works like a charm.

ACK

[kYc0o]

@aabadie can you put the flag "ready for ci" to make murdock work?

[kYc0o]

I saw some ACK so go!