CPU: Fixed include guards #5528
Conversation
|
@miri64 Sorry, I messed up with the old PR that was for "fix include guards" due to some mistaken operations, and I closed it... |
| @@ -662,5 +662,5 @@ typedef struct { | |||
| #endif | |||
|
|
|||
|
|
|||
| #endif // __LPC11UXX_H__ | |||
| #endif // LPC11UXX_H__ | |||
There was a problem hiding this comment.
Can you, while your at it change this to C-style comments (/* LPC11UXX_H__ */)?
There was a problem hiding this comment.
Sure, no problem. :-)
miri64
added
the
Type: enhancement
| /** @} */ | ||
|
|
||
| #endif /* KINETIS_CPU_USE_MCG */ | ||
| #endif /* MCG_CPU_H */ |
There was a problem hiding this comment.
@miri64 Martine, could you help check here. I though /* KINETIS_CPU_USE_MCG */ and /* MCG_CPU_H */ were misplaced in this file, and I made this revision. But I am not sure about it.
|
Please squash. |
zhuoshuguo
force-pushed
the
fix_header_include_guard
branch
from
a516247 to
f3059f1
Compare
|
squash done. |
miri64
added
the
CI: ready for build
| @@ -151,4 +151,4 @@ extern "C" { | |||
| } | |||
| #endif | |||
|
|
|||
| #endif // __LPC2387_H | |||
| #endif /* __LPC2387_H */ | |||
There was a problem hiding this comment.
Mh, this one is still (or again?) prefixed with __. Please fix and squash immediately.
There was a problem hiding this comment.
Immediate squashing can be done with git commit --amend <file> ;)
|
Apart from a minor issue: ACK, as soon as addressed and Murdock is green. |
Fix cpu/lpc2387/include/lpc2387.h
zhuoshuguo
force-pushed
the
fix_header_include_guard
branch
from
f3059f1 to
1cbe79a
Compare
|
Minor issue fixed. |
|
Could you remove the trailing double underscores in the lpc files please? Other than that, (untested) ACK. |
|
Sorry, I got some old mail notifications about this PR, I see that it's already merged |
|
I actually prefer at least one, to differentiate them from normal macros, that's why I ACK'd regardless ;) |
Pull request created as per the issue #2623